From 8ba0f875c861e8016dbe8bcda534ee5135c71f57 Mon Sep 17 00:00:00 2001 From: Hanno Braun Date: Wed, 5 Jun 2024 21:11:44 +0200 Subject: [PATCH] Simplify through hole operation --- crates/fj-core/src/operations/holes.rs | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/crates/fj-core/src/operations/holes.rs b/crates/fj-core/src/operations/holes.rs index 9155b8c7c..fb1340cbc 100644 --- a/crates/fj-core/src/operations/holes.rs +++ b/crates/fj-core/src/operations/holes.rs @@ -10,7 +10,6 @@ use crate::{ use super::{ build::{BuildCycle, BuildRegion}, - join::JoinCycle, sweep::{SweepCache, SweepRegion}, update::{UpdateFace, UpdateRegion, UpdateShell}, }; @@ -115,12 +114,7 @@ impl AddHole for Shell { let hole = swept_region.side_faces.into_iter().collect::>(); - let exit = swept_region - .top_face - .region() - .exterior() - .half_edges() - .only(); + let exit = swept_region.top_face.region().exterior(); self.update_face( entry_location.face, @@ -136,19 +130,7 @@ impl AddHole for Shell { exit_location.face, |face, core| { [face.update_region( - |region, core| { - region.add_interiors( - [Cycle::empty().add_joined_edges( - [( - exit.clone(), - *core.layers.geometry.of_half_edge(exit), - )], - exit_location.face.surface().clone(), - core, - )], - core, - ) - }, + |region, core| region.add_interiors([exit.clone()], core), core, )] },