rei-mirrors/Fornjot
1
0
Fork 0
mirror of https://github.com/hannobraun/Fornjot synced 2025-02-12 10:15:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve error handling of Tolerance

Browse Source
This commit is contained in:
Hanno Braun 2022-04-12 17:06:30 +02:00
parent 518d51387d
commit 5f7ba6ae83
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fj-kernel/src/algorithms/approximation.rs
View File

@ -184,11 +184,13 @@ impl Tolerance {
/// Construct a `Tolerance` from a [`Scalar`]
///
/// Returns an error, if the passed scalar is not larger than zero.
pub fn from_scalar(scalar: impl Into<Scalar>) -> Result<Self, Scalar> {
pub fn from_scalar(
scalar: impl Into<Scalar>,
) -> Result<Self, InvalidTolerance> {
let scalar = scalar.into();
if scalar <= Scalar::ZERO {
return Err(scalar);
return Err(InvalidTolerance(scalar));
}
Ok(Self(scalar))
@ -209,6 +211,10 @@ where
}
}
#[derive(Debug, thiserror::Error)]
#[error("Invalid tolerance ({0}); must be above zero")]
pub struct InvalidTolerance(Scalar);
#[cfg(test)]
mod tests {
use fj_math::{Point, Scalar};