From 13b201bab9fdc6b0d1cab8da8752fff2802aff63 Mon Sep 17 00:00:00 2001 From: Hanno Braun Date: Tue, 29 Mar 2022 18:17:47 +0200 Subject: [PATCH] Remove `fj::Sweep::color` It's not necessary, as it's just an alias for a method that is almost as easy to access. And it's confusing, as it implies that a sweep has its own color that's potentially separate from the swept shape. --- fj-operations/src/sweep.rs | 2 +- fj/src/shape_3d.rs | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/fj-operations/src/sweep.rs b/fj-operations/src/sweep.rs index 15f816fc8..0a2dab176 100644 --- a/fj-operations/src/sweep.rs +++ b/fj-operations/src/sweep.rs @@ -10,7 +10,7 @@ impl ToShape for fj::Sweep { self.shape().to_shape(tolerance, debug_info), Vector::from([0., 0., self.length()]), tolerance, - self.color(), + self.shape().color(), ) } diff --git a/fj/src/shape_3d.rs b/fj/src/shape_3d.rs index be6ae2ba1..2962afc27 100644 --- a/fj/src/shape_3d.rs +++ b/fj/src/shape_3d.rs @@ -113,11 +113,6 @@ impl Sweep { pub fn length(&self) -> f64 { self.length } - - /// Access the color of the shape being swept - pub fn color(&self) -> [u8; 4] { - self.shape().color() - } } impl From for Shape {