rei-forks
/
zfs-installer
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

CI: Always download the latest Shellcheck version 

The previous logic was also semantically incorrect, as the file was never cached, therefore, the `if` was redundant.
This commit is contained in:
Saverio Miroddi 2021-04-24 09:56:14 +02:00
parent 6bdb11b6a8
commit b83243d3f2
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
ci/run_shellcheck.sh
View File

@ -6,15 +6,19 @@ set -o nounset
set -o errtrace
shopt -s inherit_errexit
if [[ ! -e /opt/shellcheck/shellcheck ]]; then
mkdir -p /opt/shellcheck
# Always download the latest version:
#
# - it's fast and stable enough not to worry about it;
# - the workflow is basically single-person, so there's no risk of a new dev encountering an error found
# by a new shellcheck version.
wget -qO- https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz \
| tar xJv -O shellcheck-stable/shellcheck \
> /opt/shellcheck/shellcheck
mkdir -p /opt/shellcheck
chmod +x /opt/shellcheck/shellcheck
fi
wget -qO- https://github.com/koalaman/shellcheck/releases/download/stable/shellcheck-stable.linux.x86_64.tar.xz \
| tar xJv -O shellcheck-stable/shellcheck \
> /opt/shellcheck/shellcheck
chmod +x /opt/shellcheck/shellcheck
/opt/shellcheck/shellcheck --version