From 3bca006083f792e0b210af7836ad7fbb3b3539d6 Mon Sep 17 00:00:00 2001 From: Saverio Miroddi Date: Sun, 26 Apr 2020 22:42:20 +0200 Subject: [PATCH 1/3] README: Update Ubuntu installer comparison section --- README.md | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index f8706c0..043a25d 100644 --- a/README.md +++ b/README.md @@ -28,14 +28,22 @@ RAID-1 (mirroring) is supported, with any arbitrary number of disks; the boot an It's fairly easy to extend the program to support other Debian-based operating systems (e.g. older/newer Ubuntu's, etc.) - the project is (very) open to feature requests. -## Advantages over the Ubuntu built-in installer +## Comparison with Ubuntu built-in installer -With Ubuntu 19.10, Canonical released an experimental ZFS installer. The advantages of this project over this installer are: +As of 20.04, Canonical makes available an experimental ZFS installer on Ubuntu Desktop. -1. on production systems, it's undesirable to use a non-LTS version; -2. the experimental Ubuntu installer is unconfigurable; it generates a fixed setup. +The advantages of this project over the Ubuntu installer are: -additionally, as explained in the previous section, the script can be easily adapted for other operating systems. +1. it supports pools configuration; +2. it allows customization of the disks setup (including mirroring); +3. it supports additional features (e.g. encryption); +4. it supports many more operating systems; +5. it supports unattended installations, via custom scripts; +6. it's easy to extend. + +The disadvantages are: + +1. the Ubuntu installer has a more sophisticated filesystem layout - it separates base directories into different ZFS filesystems (this is planned to be implemented in the ZFS installer as well). ## Instructions From 5a2ee7d7b8f1151d698aacd0633e54513e95d5bd Mon Sep 17 00:00:00 2001 From: Saverio Miroddi Date: Sun, 26 Apr 2020 22:45:56 +0200 Subject: [PATCH 2/3] README: Update issues section --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 043a25d..07b487d 100644 --- a/README.md +++ b/README.md @@ -64,12 +64,12 @@ Ubuntu Server requires a slightly different execution procedure: the rest is the same as the generic procedure. -### Issues/unsupported systems - -Due to a current problem with the zpool expansion, 12 GiB of empty space are left at the end of each disk. +### Unsupported systems/Issues The Ubuntu Server alternate (non-live) version is not supported, as it's based on the Busybox environment, which lacks several tools used in the installer (apt, rsync...). +The installer itself can run over SSH (\[S\]Ubiquity of course needs to be still run in the desktop environment, unless a custom script is provided), however, GNU Screen sessions may break, due to the virtual filesystems rebinding/chrooting. This is not an issue with the ZFS installer; it's a necessary step of the destination configuration. + ### Unattended installations The program supports unattended installation, via environment variables. The program built-in help explains all the options: From 735fed10a0619873693c2d4647f7d3b29c1ce2e8 Mon Sep 17 00:00:00 2001 From: David Trounce Date: Sun, 26 Apr 2020 15:05:15 -0700 Subject: [PATCH 3/3] Remove temp partitions from all disks Puts the removal of the temp partitions in the loop, to remove these partitions from all disks --- install-zfs.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/install-zfs.sh b/install-zfs.sh index 0438b65..2a36d6b 100755 --- a/install-zfs.sh +++ b/install-zfs.sh @@ -923,8 +923,6 @@ function sync_os_temp_installation_dir_to_rpool { function remove_temp_partition_and_expand_rpool { print_step_info_header - parted -s "${v_selected_disks[0]}" rm 4 - if [[ $v_free_tail_space -eq 0 ]]; then local resize_reference=100% else @@ -932,6 +930,7 @@ function remove_temp_partition_and_expand_rpool { fi for selected_disk in "${v_selected_disks[@]}"; do + parted -s "$selected_disk" rm 4 parted -s "$selected_disk" unit s resizepart 3 -- "$resize_reference" zpool online -e "$v_rpool_name" "$selected_disk-part3" done