rei-forks/fred
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

edit prediction: Don't show and discard completion if toggled off in the buffer (#24927)

Browse Source 
Discards an inline completion when it's toggled to off (using, say, a
keyboard shortcut). This matches the behaviour in VS Code and JetBrains,
and I think is a bit more intuitive.

(https://github.com/zed-industries/zed/discussions/24895)

Release Notes:

- N/A
This commit is contained in:
itsaphel 2025-02-20 20:02:31 +00:00 committed by GitHub
parent 2581f8be92
commit 191a1d7b10
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/editor/src/editor.rs
View File

@ -1953,7 +1953,12 @@ impl Editor {
cx: &mut Context<Self>, cx: &mut Context<Self>,
) { ) {
self.show_inline_completions_override = show_edit_predictions; self.show_inline_completions_override = show_edit_predictions;
self.refresh_inline_completion(false, true, window, cx);
if let Some(false) = show_edit_predictions {
self.discard_inline_completion(false, cx);
} else {
self.refresh_inline_completion(false, true, window, cx);
}
} }
fn inline_completions_disabled_in_scope( fn inline_completions_disabled_in_scope(