rei-forks/element-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

crypto: Add some TODOs about locking

Browse Source
This commit is contained in:
Damir Jelić 2021-03-31 11:38:15 +02:00
parent 10c7f5b989
commit dc8711be30
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/crypto/DefaultCryptoService.kt
View File

@ -694,6 +694,7 @@ internal class DefaultCryptoService @Inject constructor(
} }
private suspend fun preshareGroupSession(roomId: String, roomMembers: List<String>) { private suspend fun preshareGroupSession(roomId: String, roomMembers: List<String>) {
// TODO this needs to be locked per room
val request = olmMachine!!.getMissingSessions(roomMembers) val request = olmMachine!!.getMissingSessions(roomMembers)
if (request != null) { if (request != null) {
@ -772,6 +773,7 @@ internal class DefaultCryptoService @Inject constructor(
} }
private suspend fun claimKeys(request: Request.KeysClaim) { private suspend fun claimKeys(request: Request.KeysClaim) {
// TODO this needs to be locked per call
val claimParams = ClaimOneTimeKeysForUsersDeviceTask.Params(request.oneTimeKeys) val claimParams = ClaimOneTimeKeysForUsersDeviceTask.Params(request.oneTimeKeys)
val response = oneTimeKeysForUsersDeviceTask.execute(claimParams) val response = oneTimeKeysForUsersDeviceTask.execute(claimParams)
val adapter = MoshiProvider val adapter = MoshiProvider
@ -783,6 +785,7 @@ internal class DefaultCryptoService @Inject constructor(
} }
private suspend fun sendOutgoingRequests() { private suspend fun sendOutgoingRequests() {
// TODO this needs to be locked per call
// TODO these requests should be sent out in parallel // TODO these requests should be sent out in parallel
for (outgoingRequest in olmMachine!!.outgoingRequests()) { for (outgoingRequest in olmMachine!!.outgoingRequests()) {
when (outgoingRequest) { when (outgoingRequest) {