Analytics: Display the opt in screen from the setting, and cleanup the code

vector/src/main/java/im/vector/app/features/analytics/ui/consent/AnalyticsConsentViewState.kt

@@ -21,12 +21,4 @@ import com.airbnb.mvrx.MavericksState
 data class AnalyticsConsentViewState(
         val userConsent: Boolean = false,
         val didAskUserConsent: Boolean = false
-) : MavericksState {
+) : MavericksState
-    val shouldCheckTheBox: Boolean =
-            if (didAskUserConsent) {
-                userConsent
-            } else {
-                // default value
-                true
-            }
-}

vector/src/main/java/im/vector/app/features/settings/VectorSettingsSecurityPrivacyFragment.kt

@@ -288,7 +288,7 @@ class VectorSettingsSecurityPrivacyFragment @Inject constructor(
     }
 
     private fun observeAnalyticsState() {
-        analyticsConsentViewModel.onEach(AnalyticsConsentViewState::shouldCheckTheBox) {
+        analyticsConsentViewModel.onEach(AnalyticsConsentViewState::userConsent) {
             analyticsConsent.isChecked = it
         }
     }
@@ -296,8 +296,15 @@ class VectorSettingsSecurityPrivacyFragment @Inject constructor(
     private fun setUpAnalytics() {
         analyticsCategory.isVisible = analyticsConfig.isEnabled
 
-        analyticsConsent.setOnPreferenceClickListener {
+        analyticsConsent.setOnPreferenceChangeListener { _, newValue ->
-            analyticsConsentViewModel.handle(AnalyticsConsentViewActions.SetUserConsent(analyticsConsent.isChecked))
+            val newValueBool = newValue as? Boolean ?: false
+            if (newValueBool) {
+                // User want to enable analytics, display the opt in screen
+                navigator.openAnalyticsOptIn(requireContext())
+            } else {
+                // Just disable analytics
+                analyticsConsentViewModel.handle(AnalyticsConsentViewActions.SetUserConsent(false))
+            }
             true
         }
     }