From bcf315aece5f69595ac8792f409a4770197dda20 Mon Sep 17 00:00:00 2001
From: Maxime NATUREL <maxime.naturel@niji.fr>
Date: Fri, 7 Oct 2022 10:11:04 +0200
Subject: [PATCH] Fix UI for long session names in SessionDetailsContentItem

---
 .../layout/item_session_details_content.xml   | 22 +++++++++++++------
 .../layout/item_session_details_header.xml    |  3 ++-
 2 files changed, 17 insertions(+), 8 deletions(-)

diff --git a/vector/src/main/res/layout/item_session_details_content.xml b/vector/src/main/res/layout/item_session_details_content.xml
index fefae65b3d..98a21aa923 100644
--- a/vector/src/main/res/layout/item_session_details_content.xml
+++ b/vector/src/main/res/layout/item_session_details_content.xml
@@ -3,8 +3,7 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content"
-    android:paddingTop="14dp">
+    android:layout_height="wrap_content">
 
     <TextView
         android:id="@+id/sessionDetailsContentTitle"
@@ -12,9 +11,10 @@
         android:layout_width="0dp"
         android:layout_height="wrap_content"
         android:layout_marginStart="@dimen/layout_horizontal_margin"
+        app:layout_constraintBottom_toTopOf="@id/sessionDetailsContentDivider"
         app:layout_constraintEnd_toStartOf="@id/sessionDetailsContentDescription"
         app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toTopOf="parent"
+        app:layout_constraintTop_toTopOf="@id/sessionDetailsContentTop"
         tools:text="Session name" />
 
     <TextView
@@ -25,26 +25,34 @@
         android:layout_marginStart="8dp"
         android:layout_marginEnd="@dimen/layout_horizontal_margin"
         android:gravity="end"
+        app:layout_constraintBottom_toTopOf="@id/sessionDetailsContentDivider"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toEndOf="@id/sessionDetailsContentTitle"
-        app:layout_constraintTop_toTopOf="parent"
-        tools:text="Element Web: Firefox on macOS" />
+        app:layout_constraintTop_toTopOf="@id/sessionDetailsContentTop"
+        tools:text="Element Web: Firefox" />
 
     <View
         android:id="@+id/sessionDetailsContentDivider"
         android:layout_width="0dp"
         android:layout_height="1dp"
-        android:layout_marginTop="14dp"
         android:background="@drawable/divider_horizontal"
         app:layout_constraintEnd_toEndOf="@id/sessionDetailsContentDescription"
         app:layout_constraintStart_toStartOf="@id/sessionDetailsContentTitle"
-        app:layout_constraintTop_toBottomOf="@id/sessionDetailsContentBarrier" />
+        app:layout_constraintTop_toTopOf="@id/sessionDetailsContentBarrier" />
 
     <androidx.constraintlayout.widget.Barrier
         android:id="@+id/sessionDetailsContentBarrier"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         app:barrierDirection="bottom"
+        app:barrierMargin="14dp"
         app:constraint_referenced_ids="sessionDetailsContentTitle, sessionDetailsContentDescription" />
 
+    <androidx.constraintlayout.widget.Guideline
+        android:id="@+id/sessionDetailsContentTop"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:orientation="horizontal"
+        app:layout_constraintGuide_begin="14dp" />
+
 </androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/vector/src/main/res/layout/item_session_details_header.xml b/vector/src/main/res/layout/item_session_details_header.xml
index 571a541b2b..64e0efac1f 100644
--- a/vector/src/main/res/layout/item_session_details_header.xml
+++ b/vector/src/main/res/layout/item_session_details_header.xml
@@ -3,7 +3,8 @@
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
-    android:layout_height="wrap_content">
+    android:layout_height="wrap_content"
+    android:paddingBottom="10dp">
 
     <TextView
         android:id="@+id/sessionDetailsHeaderTitle"