Simplify thread timeline toolbar menu more

This commit is contained in:
ariskotsomitopoulos 2022-03-22 18:03:49 +02:00
parent bc9a785a59
commit b1c4ca7816
2 changed files with 19 additions and 28 deletions

View File

@ -706,7 +706,9 @@ class TimelineViewModel @AssistedInject constructor(
if (initialState.isThreadTimeline()) { if (initialState.isThreadTimeline()) {
when (itemId) { when (itemId) {
R.id.menu_thread_timeline_more -> true R.id.menu_thread_timeline_view_in_room,
R.id.menu_thread_timeline_copy_link,
R.id.menu_thread_timeline_share -> true
else -> false else -> false
} }
} else { } else {

View File

@ -65,36 +65,25 @@
app:showAsAction="never" app:showAsAction="never"
tools:visible="true" /> tools:visible="true" />
<item
android:id="@+id/menu_thread_timeline_more"
android:icon="@drawable/ic_more_vertical"
android:title="@string/action_thread_view_in_room"
app:iconTint="?vctr_content_secondary"
app:showAsAction="always">
<menu>
<item <item
android:id="@+id/menu_thread_timeline_view_in_room" android:id="@+id/menu_thread_timeline_view_in_room"
android:icon="@drawable/ic_thread_view_in_room_menu_item" android:icon="@drawable/ic_thread_view_in_room_menu_item"
android:title="@string/action_thread_view_in_room" android:title="@string/action_thread_view_in_room"
app:iconTint="?vctr_content_secondary" app:iconTint="?vctr_content_secondary"
app:showAsAction="ifRoom" /> app:showAsAction="never" />
<item <item
android:id="@+id/menu_thread_timeline_copy_link" android:id="@+id/menu_thread_timeline_copy_link"
android:icon="@drawable/ic_thread_link_menu_item" android:icon="@drawable/ic_thread_link_menu_item"
android:title="@string/action_thread_copy_link_to_thread" android:title="@string/action_thread_copy_link_to_thread"
app:iconTint="?vctr_content_secondary" app:iconTint="?vctr_content_secondary"
app:showAsAction="ifRoom" /> app:showAsAction="never" />
<item <item
android:id="@+id/menu_thread_timeline_share" android:id="@+id/menu_thread_timeline_share"
android:icon="@drawable/ic_thread_share_menu_item" android:icon="@drawable/ic_thread_share_menu_item"
android:title="@string/action_share" android:title="@string/action_share"
app:iconTint="?vctr_content_secondary" app:iconTint="?vctr_content_secondary"
app:showAsAction="ifRoom" /> app:showAsAction="never" />
</menu>
</item>
</menu> </menu>