rei-forks/element-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Code review fixes.

Browse Source
This commit is contained in:
Onuray Sahin 2022-03-17 18:30:39 +03:00
parent 33e5a206bd
commit a13ba13fb5
4 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
vector/src/main/java/im/vector/app/core/utils/PermissionsTools.kt
View File

@ -128,6 +128,7 @@ fun checkPermissions(permissionsToBeGranted: List<String>,
.setPositiveButton(R.string.ok) { _, _ -> .setPositiveButton(R.string.ok) { _, _ ->
activityResultLauncher.launch(missingPermissions.toTypedArray()) activityResultLauncher.launch(missingPermissions.toTypedArray())
} }
.setNegativeButton(R.string.action_not_now, null)
.show() .show()
} else { } else {
// some permissions are not granted, ask permissions // some permissions are not granted, ask permissions

2
vector/src/main/java/im/vector/app/features/location/DefaultLocationSharingSettingsNavigator.kt → vector/src/main/java/im/vector/app/features/location/DefaultLocationSharingNavigator.kt
View File

@ -19,7 +19,7 @@ package im.vector.app.features.location
import android.app.Activity import android.app.Activity
import im.vector.app.core.utils.openAppSettingsPage import im.vector.app.core.utils.openAppSettingsPage
class DefaultLocationSharingSettingsNavigator constructor(val activity: Activity?) : LocationSharingSettingsNavigator { class DefaultLocationSharingNavigator constructor(val activity: Activity?) : LocationSharingNavigator {
override var goingToAppSettings: Boolean = false override var goingToAppSettings: Boolean = false

2
vector/src/main/java/im/vector/app/features/location/LocationSharingFragment.kt
View File

@ -54,7 +54,7 @@ class LocationSharingFragment @Inject constructor(
private val viewModel: LocationSharingViewModel by fragmentViewModel() private val viewModel: LocationSharingViewModel by fragmentViewModel()
private val locationSharingNavigator: LocationSharingSettingsNavigator by lazy { DefaultLocationSharingSettingsNavigator(activity) } private val locationSharingNavigator: LocationSharingNavigator by lazy { DefaultLocationSharingNavigator(activity) }
// Keep a ref to handle properly the onDestroy callback // Keep a ref to handle properly the onDestroy callback
private var mapView: WeakReference<MapView>? = null private var mapView: WeakReference<MapView>? = null

2
vector/src/main/java/im/vector/app/features/location/LocationSharingSettingsNavigator.kt → vector/src/main/java/im/vector/app/features/location/LocationSharingNavigator.kt
View File

@ -16,7 +16,7 @@
package im.vector.app.features.location package im.vector.app.features.location
interface LocationSharingSettingsNavigator { interface LocationSharingNavigator {
var goingToAppSettings: Boolean var goingToAppSettings: Boolean
fun quit() fun quit()
fun goToAppSettings() fun goToAppSettings()