From 837590104d1a9c7cd06ae2b6908eb7c1eebfbd89 Mon Sep 17 00:00:00 2001
From: Benoit Marty <benoitm@matrix.org>
Date: Tue, 3 Jan 2023 11:55:32 +0100
Subject: [PATCH] Avoid launching coroutine for nothing.
---
.../sdk/internal/session/StreamEventsManager.kt | 10 ++++------
.../session/sync/handler/room/RoomSyncHandler.kt | 4 +++-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/StreamEventsManager.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/StreamEventsManager.kt
index cfc26045a0..ce34b0430e 100644
--- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/StreamEventsManager.kt
+++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/StreamEventsManager.kt
@@ -42,14 +42,12 @@ internal class StreamEventsManager @Inject constructor() {
listeners.remove(listener)
}
- fun dispatchLiveEventReceived(event: Event, roomId: String, initialSync: Boolean) {
+ fun dispatchLiveEventReceived(event: Event, roomId: String) {
Timber.v("## dispatchLiveEventReceived ${event.eventId}")
coroutineScope.launch {
- if (!initialSync) {
- listeners.forEach {
- tryOrNull {
- it.onLiveEvent(roomId, event)
- }
+ listeners.forEach {
+ tryOrNull {
+ it.onLiveEvent(roomId, event)
}
}
}
diff --git a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt
index 4001ae2ccf..d67b903bb9 100644
--- a/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt
+++ b/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/sync/handler/room/RoomSyncHandler.kt
@@ -423,7 +423,9 @@ internal class RoomSyncHandler @Inject constructor(
val isInitialSync = insertType == EventInsertType.INITIAL_SYNC
eventIds.add(event.eventId)
- liveEventService.get().dispatchLiveEventReceived(event, roomId, isInitialSync)
+ if (!isInitialSync) {
+ liveEventService.get().dispatchLiveEventReceived(event, roomId)
+ }
if (event.isEncrypted() && !isInitialSync) {
try {