rei-forks/element-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

explicitly declaring the fake registrationb wizard as not relaxed and creating new test instances for each case

Browse Source
This commit is contained in:
Adam Brown 2022-03-18 13:15:14 +00:00
parent abf62aff47
commit 7f943d37fd
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
vector/src/test/java/im/vector/app/features/onboarding/RegistrationActionHandlerTest.kt
View File

@ -37,9 +37,6 @@ private val A_PID_TO_REGISTER = RegisterThreePid.Email("an email")
class RegistrationActionHandlerTest { class RegistrationActionHandlerTest {
private val fakeRegistrationWizard = FakeRegistrationWizard()
private val registrationActionHandler = RegistrationActionHandler()
@Test @Test
fun `when handling register action then delegates to wizard`() = runBlockingTest { fun `when handling register action then delegates to wizard`() = runBlockingTest {
val cases = listOf( val cases = listOf(
@ -60,6 +57,8 @@ class RegistrationActionHandlerTest {
} }
private suspend fun testSuccessfulActionDelegation(case: Case) { private suspend fun testSuccessfulActionDelegation(case: Case) {
val registrationActionHandler = RegistrationActionHandler()
val fakeRegistrationWizard = FakeRegistrationWizard()
fakeRegistrationWizard.givenSuccessFor(result = A_SESSION, case.expect) fakeRegistrationWizard.givenSuccessFor(result = A_SESSION, case.expect)
val result = registrationActionHandler.handleRegisterAction(fakeRegistrationWizard, case.action) val result = registrationActionHandler.handleRegisterAction(fakeRegistrationWizard, case.action)
@ -71,3 +70,5 @@ class RegistrationActionHandlerTest {
private fun case(action: RegisterAction, expect: suspend RegistrationWizard.() -> RegistrationResult) = Case(action, expect) private fun case(action: RegisterAction, expect: suspend RegistrationWizard.() -> RegistrationResult) = Case(action, expect)
private class Case(val action: RegisterAction, val expect: suspend RegistrationWizard.() -> RegistrationResult) private class Case(val action: RegisterAction, val expect: suspend RegistrationWizard.() -> RegistrationResult)

2
vector/src/test/java/im/vector/app/test/fakes/FakeRegistrationWizard.kt
View File

@ -22,7 +22,7 @@ import org.matrix.android.sdk.api.auth.registration.RegistrationResult
import org.matrix.android.sdk.api.auth.registration.RegistrationWizard import org.matrix.android.sdk.api.auth.registration.RegistrationWizard
import org.matrix.android.sdk.api.session.Session import org.matrix.android.sdk.api.session.Session
class FakeRegistrationWizard : RegistrationWizard by mockk() { class FakeRegistrationWizard : RegistrationWizard by mockk(relaxed = false) {
fun givenSuccessFor(result: Session, expect: suspend RegistrationWizard.() -> RegistrationResult) { fun givenSuccessFor(result: Session, expect: suspend RegistrationWizard.() -> RegistrationResult) {
coEvery { expect(this@FakeRegistrationWizard) } returns RegistrationResult.Success(result) coEvery { expect(this@FakeRegistrationWizard) } returns RegistrationResult.Success(result)