rei-forks/element-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #3797 from vector-im/feature/ons/fix_voice_message_crash

Browse Source 
Voice Message - Fix amplitude update java.util.ConcurrentModificationException
This commit is contained in:
Onuray Sahin 2021-08-05 16:36:25 +03:00 committed by GitHub
commit 78653eb1d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/3796.bugfix Normal file
View File

@ -0,0 +1 @@
Voice Message - Amplitude update java.util.ConcurrentModificationException

14
vector/src/main/java/im/vector/app/features/home/room/detail/composer/VoiceMessageRecorderView.kt
View File

@ -326,11 +326,11 @@ class VoiceMessageRecorderView @JvmOverloads constructor(
} }
} }
private fun renderRecordingWaveform(amplitudeList: List<Int>) { private fun renderRecordingWaveform(amplitudeList: Array<Int>) {
views.voicePlaybackWaveform.apply { post {
post { views.voicePlaybackWaveform.apply {
amplitudeList.forEach { amplitude -> amplitudeList.iterator().forEach {
update(amplitude) update(it)
} }
} }
} }
@ -404,7 +404,7 @@ class VoiceMessageRecorderView @JvmOverloads constructor(
scaleX = 1f scaleX = 1f
scaleY = 1f scaleY = 1f
translationX = 0f translationX = 0f
translationY = 0f translationY = 0f
} }
isCancelled?.let { isCancelled?.let {
callback?.onVoiceRecordingEnded(it) callback?.onVoiceRecordingEnded(it)
@ -503,7 +503,7 @@ class VoiceMessageRecorderView @JvmOverloads constructor(
override fun onUpdate(state: VoiceMessagePlaybackTracker.Listener.State) { override fun onUpdate(state: VoiceMessagePlaybackTracker.Listener.State) {
when (state) { when (state) {
is VoiceMessagePlaybackTracker.Listener.State.Recording -> { is VoiceMessagePlaybackTracker.Listener.State.Recording -> {
renderRecordingWaveform(state.amplitudeList) renderRecordingWaveform(state.amplitudeList.toTypedArray())
} }
is VoiceMessagePlaybackTracker.Listener.State.Playing -> { is VoiceMessagePlaybackTracker.Listener.State.Playing -> {
views.voicePlaybackControlButton.setImageResource(R.drawable.ic_play_pause_pause) views.voicePlaybackControlButton.setImageResource(R.drawable.ic_play_pause_pause)