view room excessive tracks fixed, added active space property to space switch event

vector/src/main/java/im/vector/app/features/analytics/experiment/ExperimentInteraction.kt

@@ -31,6 +31,7 @@ data class ExperimentInteraction(
         SpaceSwitchHeader,
         SpaceSwitchHeaderAdd,
         SpaceSwitchHeaderCreate,
+        SpacePanelSwitchSpace
     }
 
     override fun getName() = "Interaction"

vector/src/main/java/im/vector/app/features/home/HomeDetailViewModel.kt

@@ -228,8 +228,22 @@ class HomeDetailViewModel @AssistedInject constructor(
         appStateHandler.setCurrentSpace(space?.roomId)
     }
 
+    private fun trackSpaceSwitch(){
+        when (val groupingMethod = appStateHandler.getCurrentRoomGroupingMethod()) {
+            is RoomGroupingMethod.ByLegacyGroup -> {
+                // TODO!!
+            }
+            is RoomGroupingMethod.BySpace       -> {
+                groupingMethod.spaceSummary?.toAnalyticsViewRoom(null, groupingMethod)?.let {
+                    analyticsTracker.capture(it)
+                }
+            }
+        }
+    }
+
     private fun observeRoomSummaries() {
         appStateHandler.selectedRoomGroupingFlow.distinctUntilChanged().flatMapLatest {
+            trackSpaceSwitch()
             // we use it as a trigger to all changes in room, but do not really load
             // the actual models
             session.roomService().getPagedRoomSummariesLive(
@@ -294,9 +308,6 @@ class HomeDetailViewModel @AssistedInject constructor(
                                         hasUnreadMessages = dmRooms.totalCount + otherRooms.totalCount > 0
                                 )
                             }
-                            groupingMethod.spaceSummary?.toAnalyticsViewRoom(null, groupingMethod)?.let {
-                                analyticsTracker.capture(it)
-                            }
                         }
                         null                                -> Unit
                     }

vector/src/main/java/im/vector/app/features/spaces/SpaceListViewModel.kt

@@ -30,7 +30,7 @@ import im.vector.app.core.di.MavericksAssistedViewModelFactory
 import im.vector.app.core.di.hiltMavericksViewModelFactory
 import im.vector.app.core.platform.VectorViewModel
 import im.vector.app.features.analytics.AnalyticsTracker
-import im.vector.app.features.analytics.plan.Interaction
+import im.vector.app.features.analytics.experiment.ExperimentInteraction
 import im.vector.app.features.invite.AutoAcceptInvites
 import im.vector.app.features.session.coroutineScope
 import im.vector.app.features.settings.VectorPreferences
@@ -234,14 +234,13 @@ class SpaceListViewModel @AssistedInject constructor(@Assisted initialState: Spa
 
     private fun handleSelectSpace(action: SpaceListAction.SelectSpace) = withState { state ->
         val groupingMethod = state.selectedGroupingMethod
+        val isAtSpace = groupingMethod.space() != null
         if (groupingMethod is RoomGroupingMethod.ByLegacyGroup || groupingMethod.space()?.roomId != action.spaceSummary?.roomId) {
-            analyticsTracker.capture(Interaction(null, null, Interaction.Name.SpacePanelSwitchSpace))
             setState { copy(selectedGroupingMethod = RoomGroupingMethod.BySpace(action.spaceSummary)) }
             appStateHandler.setCurrentSpace(action.spaceSummary?.roomId)
             _viewEvents.post(SpaceListViewEvents.OpenSpace(groupingMethod is RoomGroupingMethod.ByLegacyGroup))
-        } else {
-            analyticsTracker.capture(Interaction(null, null, Interaction.Name.SpacePanelSelectedSpace))
         }
+        analyticsTracker.capture(ExperimentInteraction(ExperimentInteraction.Name.SpacePanelSwitchSpace, mapOf("isSubspace" to isAtSpace)))
     }
 
     private fun handleSelectGroup(action: SpaceListAction.SelectLegacyGroup) = withState { state ->