rei-forks/element-android
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Code review cleaning

Browse Source
This commit is contained in:
Valere 2021-06-15 12:20:26 +02:00
parent 19a2b56011
commit 301251262d
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
vector/src/main/java/im/vector/app/features/spaces/create/CreateSpaceViewModel.kt
View File

@ -92,16 +92,24 @@ class CreateSpaceViewModel @AssistedInject constructor(
_viewEvents.post(CreateSpaceEvents.NavigateToDetails) _viewEvents.post(CreateSpaceEvents.NavigateToDetails)
} }
is CreateSpaceAction.NameChanged -> { is CreateSpaceAction.NameChanged -> {
val tentativeAlias =
getAliasFromName(action.name)
setState { setState {
copy( if (aliasManuallyModified) {
nameInlineError = null, copy(
name = action.name, nameInlineError = null,
aliasLocalPart = tentativeAlias, name = action.name,
aliasVerificationTask = Uninitialized aliasVerificationTask = Uninitialized
) )
} else {
val tentativeAlias =
getAliasFromName(action.name)
copy(
nameInlineError = null,
name = action.name,
aliasLocalPart = tentativeAlias,
aliasVerificationTask = Uninitialized
)
}
} }
} }
is CreateSpaceAction.TopicChanged -> { is CreateSpaceAction.TopicChanged -> {
@ -112,6 +120,8 @@ class CreateSpaceViewModel @AssistedInject constructor(
} }
} }
is CreateSpaceAction.SpaceAliasChanged -> { is CreateSpaceAction.SpaceAliasChanged -> {
// This called only when the alias is change manually
// not when programmatically changed via a change on name
setState { setState {
copy( copy(
aliasManuallyModified = true, aliasManuallyModified = true,
@ -237,7 +247,7 @@ class CreateSpaceViewModel @AssistedInject constructor(
_viewEvents.post(CreateSpaceEvents.NavigateToChoosePrivateType) _viewEvents.post(CreateSpaceEvents.NavigateToChoosePrivateType)
} else { } else {
// it'a public space, let's check alias // it'a public space, let's check alias
val aliasLocalPart = if (state.aliasManuallyModified) state.aliasLocalPart else getAliasFromName(state.name) val aliasLocalPart = state.aliasLocalPart
_viewEvents.post(CreateSpaceEvents.ShowModalLoading(null)) _viewEvents.post(CreateSpaceEvents.ShowModalLoading(null))
setState { setState {
copy(aliasVerificationTask = Loading()) copy(aliasVerificationTask = Loading())
@ -280,7 +290,7 @@ class CreateSpaceViewModel @AssistedInject constructor(
viewModelScope.launch(Dispatchers.IO) { viewModelScope.launch(Dispatchers.IO) {
try { try {
val alias = if (state.spaceType == SpaceType.Public) { val alias = if (state.spaceType == SpaceType.Public) {
if (state.aliasManuallyModified) state.aliasLocalPart else getAliasFromName(state.name) state.aliasLocalPart
} else null } else null
val result = createSpaceViewModelTask.execute( val result = createSpaceViewModelTask.execute(
CreateSpaceTaskParams( CreateSpaceTaskParams(