Merge pull request #3459 from mozilla/move-linter-circleci

Move linting job to CircleCI

.circleci/config.yml

@@ -72,6 +72,30 @@ jobs:
               docker push "${DOCKERHUB_REPO}:${CIRCLE_TAG}"
             fi
 
+  lint:
+    docker:
+      - image: circleci/python:3.7.9
+    steps:
+      - checkout
+      - run:
+          name: Install dependencies
+          command: |
+            pip install --upgrade cardboardlint pylint
+      - run:
+          name: Run linter
+          command: |
+            set -ex
+            # Check if branch can be merged with master (if failing script will stop due to set -e)
+            git config user.email "you@example.com"
+            git config user.name "Your Name"
+            git merge --no-commit --no-ff origin/master
+
+            # Undo merge changes if any
+            git reset --hard $CIRCLE_BRANCH
+
+            # Lint differences against master
+            cardboardlinter --refspec origin/master -n auto;
+
 workflows:
   version: 2
   build-deploy:
@@ -87,3 +111,7 @@ workflows:
           filters:
             tags:
               only: /.*/
+
+  lint:
+    jobs:
+      - lint

.travis.yml

@@ -1,22 +0,0 @@
-language: python
-
-cache: pip
-before_cache:
-  - rm ~/.cache/pip/log/debug.log
-
-python:
-  - "3.6"
-
-jobs:
-  include:
-    - name: cardboard linter
-      install:
-        - pip install --upgrade cardboardlint pylint
-      script: |
-        # Run cardboardlinter, in case of pull requests
-        if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then
-          if [ "$TRAVIS_BRANCH" != "master" ]; then
-            git fetch origin $TRAVIS_BRANCH:$TRAVIS_BRANCH
-          fi
-          cardboardlinter --refspec $TRAVIS_BRANCH -n auto;
-        fi