583b7418a6
Currently, the constructor of ConvolutionGroupConverter allows to specify canonicalize_depthwise_filter without specifying what it does (assigning it to a variable called filter_expansion). Then this is used to initialize the filter_expansion variable of visitor with !filter_expansion. So essentially one needed to pass 'false' if the filter expansion should be done. This CL makes it clearer by using always the variable name filter_expansion and avoids the intermediate negation step. No functional change. PiperOrigin-RevId: 288647349 Change-Id: I0f2984f403d6b4e0cc88405bd05234cb6a7b8a92
59 lines
2.2 KiB
C++
59 lines
2.2 KiB
C++
/* Copyright 2018 The TensorFlow Authors. All Rights Reserved.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
==============================================================================*/
|
|
|
|
#ifndef TENSORFLOW_COMPILER_XLA_SERVICE_CONVOLUTION_GROUP_CONVERTER_H_
|
|
#define TENSORFLOW_COMPILER_XLA_SERVICE_CONVOLUTION_GROUP_CONVERTER_H_
|
|
|
|
#include "absl/strings/string_view.h"
|
|
#include "tensorflow/compiler/xla/service/hlo_module.h"
|
|
#include "tensorflow/compiler/xla/service/hlo_pass_interface.h"
|
|
#include "tensorflow/compiler/xla/status_macros.h"
|
|
|
|
namespace xla {
|
|
|
|
// A pass which rewrites convolutions with feature_group_count > 1 into
|
|
// convolutions with feature_group_count = 1.
|
|
class ConvolutionGroupConverter : public HloModulePass {
|
|
public:
|
|
ConvolutionGroupConverter(std::function<bool(HloInstruction*)> is_cost_viable,
|
|
bool convert_batch_groups_only,
|
|
bool filter_expansion = true)
|
|
: is_cost_viable_(is_cost_viable),
|
|
convert_batch_groups_only_(convert_batch_groups_only),
|
|
filter_expansion_(filter_expansion) {}
|
|
|
|
absl::string_view name() const override {
|
|
return "convolution-group-converter";
|
|
}
|
|
|
|
// Run convolution rewriting on the given computation. Returns whether the
|
|
// computation was changed.
|
|
StatusOr<bool> Run(HloModule* module) override;
|
|
|
|
// Lambda containing cost model that decides whether to expand
|
|
// batch_group_count.
|
|
std::function<bool(HloInstruction*)> is_cost_viable_;
|
|
|
|
// Decides whether to convert batch groups or feature groups.
|
|
bool convert_batch_groups_only_;
|
|
|
|
// Tells whether filter expansion is required.
|
|
bool filter_expansion_;
|
|
};
|
|
|
|
} // namespace xla
|
|
|
|
#endif // TENSORFLOW_COMPILER_XLA_SERVICE_CONVOLUTION_GROUP_CONVERTER_H_
|