This fix updates protobuf to 3.6.1 in install_proto3.sh.
The protobuf library in workspace.bzl has been updated to 3.6.1 for
some time, though in CI build protoc still uses 3.6.0.
When build a custom op (in docker image `tensorflow/tensorflow:custom-op`)
and using grpc's `grpc_defs()` (`grpc/bazel/grpc_deps.bzl`):
ac6795a57e/bazel/grpc_deps.bzl (L5-L7)
The issue arise because grpc's dependency is 3.6.1 (and an immediate earlier version is 3.5)
so there is no match to fit grpc+protobuf no matter which version of grpc is used.
This may not a problem for tensorflow itself as tensorflow does not call `grpc_defs()`. Tensorflow
links to protobuf 3.6.1 explicitly. Still, it would be good to match the
version of installed protoc (3.6.0) with protobuf library (3.6.1).
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
40 lines
1.5 KiB
Bash
Executable File
40 lines
1.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Copyright 2015 The TensorFlow Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
# ==============================================================================
|
|
|
|
# Install protobuf3.
|
|
|
|
# Select protobuf version.
|
|
PROTOBUF_VERSION="3.6.1"
|
|
protobuf_ver_flat=$(echo $PROTOBUF_VERSION | sed 's/\.//g' | sed 's/^0*//g')
|
|
local_protobuf_ver=$(protoc --version)
|
|
local_protobuf_ver_flat=$(echo $local_protobuf_ver | sed 's/\.//g' | sed 's/^0*//g')
|
|
if [[ -z $local_protobuf_ver_flat ]]; then
|
|
local_protobuf_ver_flat=0
|
|
fi
|
|
if (( $local_protobuf_ver_flat < $protobuf_ver_flat )); then
|
|
set -e
|
|
PROTOBUF_URL="https://github.com/google/protobuf/releases/download/v${PROTOBUF_VERSION}/protoc-${PROTOBUF_VERSION}-linux-x86_64.zip"
|
|
PROTOBUF_ZIP=$(basename "${PROTOBUF_URL}")
|
|
UNZIP_DEST="google-protobuf"
|
|
|
|
wget "${PROTOBUF_URL}"
|
|
unzip "${PROTOBUF_ZIP}" -d "${UNZIP_DEST}"
|
|
cp "${UNZIP_DEST}/bin/protoc" /usr/local/bin/
|
|
|
|
rm -f "${PROTOBUF_ZIP}"
|
|
rm -rf "${UNZIP_DEST}"
|
|
fi
|