dff3c8a47a
With the bazel version update from 3.1.0 to 3.7.2, the object file hash values are no longer added when their names are unique within an objc_library. See: * https://github.com/bazelbuild/bazel/issues/11846 * https://github.com/bazelbuild/bazel/pull/11958 However, object name collision can still happen when there is a source code with the same basename in a transitive dependency tree. Normally there is no problem with this, but this had an unfortunate interaction with the symbol hiding script we use for building the iOS static framework. That is, when an archive file (.a) contains more than one object file with the same name, the 'ar -x' command executed as part of the symbol hiding script would overwrite the conflicting object file, causing the overwritten object file to be not included in the final static framework. This was causing a link error at CocoaPods lint step, as it had some missing function definitions. This is now fixed by using a custom extraction script written in Python, which gracefully handles the object file name collision. This also fixes a previously existed race condition when the symbol hiding script is run in parallel for multiple static framework targets, by using separate temporary directories while extracting the object files. Verified that this fix works with CocoaPods lint. PiperOrigin-RevId: 351118550 Change-Id: Iec26e4720c21f271822785032d5fb6f4717eebca
80 lines
3.0 KiB
Python
80 lines
3.0 KiB
Python
# Copyright 2021 The TensorFlow Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
# ==============================================================================
|
|
# Lint as: python3
|
|
"""Tests for the extract_object_files module."""
|
|
|
|
import io
|
|
import os
|
|
import pathlib
|
|
from typing import List
|
|
from absl.testing import parameterized
|
|
from tensorflow.lite.ios import extract_object_files
|
|
from tensorflow.python.platform import resource_loader
|
|
from tensorflow.python.platform import test
|
|
|
|
|
|
class ExtractObjectFilesTest(parameterized.TestCase):
|
|
|
|
@parameterized.named_parameters(
|
|
dict(
|
|
testcase_name='Simple extraction',
|
|
dirname='simple',
|
|
object_files=['foo.o', 'bar.o']),
|
|
dict(
|
|
testcase_name='Extended filename',
|
|
dirname='extended_filename',
|
|
object_files=['short.o', 'long_file_name_with_extended_format.o']),
|
|
dict(
|
|
testcase_name='Odd bytes pad handling',
|
|
dirname='odd_bytes',
|
|
object_files=['odd.o', 'even.o']),
|
|
dict(
|
|
testcase_name='Duplicate object names should be separated out',
|
|
dirname='duplicate_names',
|
|
object_files=['foo.o', 'foo_1.o', 'foo_2.o']),
|
|
dict(
|
|
testcase_name='Exact same file should not be extracted again',
|
|
dirname='skip_same_file',
|
|
object_files=['foo.o']))
|
|
def test_extract_object_files(self, dirname: str, object_files: List[str]):
|
|
dest_dir = self.create_tempdir().full_path
|
|
input_file_relpath = os.path.join('testdata', dirname, 'input.a')
|
|
archive_path = resource_loader.get_path_to_datafile(input_file_relpath)
|
|
|
|
with open(archive_path, 'rb') as archive_file:
|
|
extract_object_files.extract_object_files(archive_file, dest_dir)
|
|
|
|
# Only the expected files should be extracted and no more.
|
|
self.assertCountEqual(object_files, os.listdir(dest_dir))
|
|
|
|
# Compare the extracted files against the expected file content.
|
|
for file in object_files:
|
|
actual = pathlib.Path(os.path.join(dest_dir, file)).read_bytes()
|
|
expected = pathlib.Path(
|
|
resource_loader.get_path_to_datafile(
|
|
os.path.join('testdata', dirname, file))).read_bytes()
|
|
self.assertEqual(actual, expected)
|
|
|
|
def test_invalid_archive(self):
|
|
with io.BytesIO(b'this is an invalid archive file') as archive_file:
|
|
with self.assertRaises(RuntimeError):
|
|
extract_object_files.extract_object_files(
|
|
archive_file,
|
|
self.create_tempdir().full_path)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
test.main()
|