Thomas Joerg 6fa992df6e [XLA:GPU] Do not fuse into bitcast ops.
Bitcasts are no-ops that do not produce any code. Hence, we're better off keeping them unfused.

PiperOrigin-RevId: 333244298
Change-Id: I3dc21b18e36343bb5b3000d9dd0ab6c83f9a2119
2020-09-23 01:27:46 -07:00

334 lines
13 KiB
C++

/* Copyright 2016 The TensorFlow Authors. All Rights Reserved.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
==============================================================================*/
#include "tensorflow/compiler/xla/service/gpu/fusion_merger.h"
#include <algorithm>
#include <vector>
#include "absl/algorithm/container.h"
#include "absl/strings/str_join.h"
#include "tensorflow/compiler/xla/service/gpu/gpu_fusible.h"
#include "tensorflow/compiler/xla/service/gpu/instruction_fusion.h"
#include "tensorflow/compiler/xla/service/hlo_cost_analysis.h"
#include "tensorflow/compiler/xla/service/llvm_ir/fused_ir_emitter.h"
#include "tensorflow/compiler/xla/shape_util.h"
#include "tensorflow/compiler/xla/util.h"
#include "tensorflow/core/lib/core/errors.h"
namespace xla {
namespace gpu {
namespace {
// Traverses users of tuple shape, adding leaf instructions to 'instructions'.
void MaybeResolveTupleElements(HloInstruction* instruction,
std::vector<HloInstruction*>* instructions) {
if (instruction->shape().IsTuple()) {
for (auto tuple_user : instruction->users()) {
MaybeResolveTupleElements(tuple_user, instructions);
}
} else {
instructions->push_back(instruction);
}
}
// Returns the bytes read by fusion parameter 'param', by returning the byte
// size of 'param' shape (or the cumulative byte sizes of all leaf tuple
// elements if 'param' is tuple-shaped).
//
// In the special case where all users of 'param' (or all users of a leaf
// tuple element if 'param' is tuple-shaped) are Slice instructions, the size
// of each slice instruction is accumulated instead, to give a more accurate
// value for bytes read.
double CalculateBytesReadByFusionParameter(HloInstruction* param) {
CHECK_EQ(HloOpcode::kParameter, param->opcode());
// Adds all leaf tuple elements to 'instructions' if 'param' is tuple-shaped.
// Adds 'param' to 'instructions' otherwise.
std::vector<HloInstruction*> instructions;
MaybeResolveTupleElements(param, &instructions);
// Iterate through 'instructions' accumulating byte sizes of each instruction
// shape. For each 'instruction' in 'instructions', if all users of
// 'instruction' are Slice instructions, accumulates the byte sizes of each
// Slice for a more accurate estimate of bytes read.
double bytes = 0.0;
for (auto& instruction : instructions) {
if (absl::c_all_of(
instruction->users(), [](const HloInstruction* instruction) {
return instruction->opcode() == HloOpcode::kSlice ||
instruction->opcode() == HloOpcode::kDynamicSlice;
})) {
// All users are slice: accumulate bytes of all user slice instructions.
for (auto& user : instruction->users()) {
bytes += ShapeUtil::ByteSizeOf(user->shape());
}
} else {
// Some users are not slice: accumulate full size of 'instruction'.
bytes += ShapeUtil::ByteSizeOf(instruction->shape());
}
}
return bytes;
}
// Returns the bytes read by all fusion parameters of instruction 'fusion'.
double CalculateBytesReadByFusionInstruction(HloInstruction* fusion) {
double bytes = 0.0;
for (auto* fused_instruction : fusion->fused_instructions()) {
if (fused_instruction->opcode() != HloOpcode::kParameter) {
continue;
}
bytes += CalculateBytesReadByFusionParameter(fused_instruction);
}
return bytes;
}
// Returns bytes transferred by instruction 'fusion', including the bytes
// that would be read by all users.
double GetCurrentBytesTransferred(HloInstruction* fusion) {
CHECK_EQ(HloOpcode::kFusion, fusion->opcode());
const double bytes_read = CalculateBytesReadByFusionInstruction(fusion);
double bytes_written = 0;
if (fusion->IsMultiOutputFusion()) {
for (auto& operand : fusion->fused_expression_root()->operands()) {
bytes_written += ShapeUtil::ByteSizeOf(operand->shape());
}
} else {
bytes_written =
ShapeUtil::ByteSizeOf(fusion->fused_expression_root()->shape());
}
// Current bytes transferred (ignoring non 'fusion' user operands) is bytes
// read and written by 'fusion', plus reads of size 'bytes_written' for each
// user.
return bytes_read + bytes_written * (fusion->user_count() + 1);
}
// Returns bytes transferred if 'fusion' were to be merged into its users.
double GetMergedBytesTransferred(HloInstruction* fusion) {
CHECK_EQ(HloOpcode::kFusion, fusion->opcode());
return CalculateBytesReadByFusionInstruction(fusion) * fusion->user_count();
}
} // anonymous namespace
// FusionInstructionMerger visits all fusion instructions in 'computation'
// in post order, attempting to merge each into all of its users.
// Accumulates and reports stats on successful/failed merge attempts.
class FusionInstructionMerger {
public:
explicit FusionInstructionMerger(HloComputation* computation)
: computation_(computation) {}
Status Run();
bool changed() const { return changed_; }
private:
Status HandleFusion(HloInstruction* fusion);
HloComputation* computation_;
bool changed_ = false;
// Fusion instruction merge stats.
int total_visited_ = 0;
int total_merged_ = 0;
int num_fail_no_users_ = 0;
int num_fail_not_loop_fusion_ = 0;
int num_fail_merge_all_users_ = 0;
int num_fail_expensive_fused_instruction_ = 0;
int num_fail_net_bytes_transferred_ratio_ = 0;
int num_fail_inefficient_fusion_emitter_ = 0;
int num_fail_fusion_too_large_ = 0;
TF_DISALLOW_COPY_AND_ASSIGN(FusionInstructionMerger);
};
Status FusionInstructionMerger::Run() {
for (auto* instruction : computation_->MakeInstructionPostOrder()) {
if (instruction->opcode() == HloOpcode::kFusion) {
TF_RETURN_IF_ERROR(HandleFusion(instruction));
}
}
VLOG(1) << "FusionInstructionMerger EXIT"
<< " computation: " << computation_->name()
<< " total_visited: " << total_visited_
<< " total_merged: " << total_merged_ << " merge failures { "
<< " no_users: " << num_fail_no_users_
<< " not_loop_fusion: " << num_fail_not_loop_fusion_
<< " merge_all_users: " << num_fail_merge_all_users_
<< " expensive_instruction: " << num_fail_expensive_fused_instruction_
<< " net_bytes_transferred: " << num_fail_net_bytes_transferred_ratio_
<< " inefficient_fusion_emitter: "
<< num_fail_inefficient_fusion_emitter_
<< " fusion_too_large: " << num_fail_fusion_too_large_ << " }";
return Status::OK();
}
Status FusionInstructionMerger::HandleFusion(HloInstruction* fusion) {
++total_visited_;
// Skip 'fusion' instruction if there are no users into which we can merge.
if (fusion->users().empty()) {
VLOG(3) << "Not merging " << fusion->name() << ": Has no users.";
++num_fail_no_users_;
return Status::OK();
}
// Skip 'fusion' instruction if it is not a loop fusion. Library fusion
// instructions match specific patterns, so they shouldn't be further fused.
// Input fusion instructions need to be rooted at a particular HLO (e.g.
// kReduce), so they shouldn't be further fused either.
if (!fusion->IsLoopFusion()) {
VLOG(3) << "Not merging " << fusion->name() << ": Is not loop fusion.";
++num_fail_not_loop_fusion_;
return Status::OK();
}
// Skip 'fusion' instruction if we cannot merge into all of its users.
// Merging into all users enables the removal of 'fusion' from the
// computation.
if (!absl::c_all_of(fusion->users(), [&](const HloInstruction* user) {
return IsProducerConsumerFusible(*fusion, *user) &&
// Do not fuse into bitcast ops, which are no-ops and do not
// generate any GPU code.
user->opcode() != HloOpcode::kBitcast;
})) {
VLOG(3) << "Not merging " << fusion->name()
<< ": Some of its users are not loop/input fusion kernels.";
++num_fail_merge_all_users_;
return Status::OK();
}
// Skip 'fusion' instruction if merging it into all users would result in a
// net increase in bytes transferred (currently allowing the net bytes
// transferred to be exceeded up to ~10% in exchange for eliminating the
// overhead from a GPU kernel launch).
const double current_bytes_transferred = GetCurrentBytesTransferred(fusion);
const double merged_bytes_transferred = GetMergedBytesTransferred(fusion);
const double merged_to_current_bytes_ratio =
merged_bytes_transferred / std::max(1.0, current_bytes_transferred);
if (merged_to_current_bytes_ratio > 1.10) {
VLOG(3) << "Not merging " << fusion->name()
<< ": merged-to-current-bytes-ratio of "
<< merged_to_current_bytes_ratio << " is not favorable.";
++num_fail_net_bytes_transferred_ratio_;
return Status::OK();
}
// Skip 'fusion' instruction if any of its fused instructions are expensive.
// This is done to avoid the duplication of expensive instructions, which
// would occur if 'fusion' were merged into multiple users.
//
// However, if we are going to save a "lot" in memory bandwidth then we
// ignore how expensive the fusion instructions are. The heuristic used to
// determine "a lot" is the following: merging must reduce memory traffic by a
// factor of 0.3, and the amount of memory accessed must not be entirely
// trivial (above 1K). This likely has room for improvement in the future.
bool allow_expensive_ops =
fusion->user_count() == 1 ||
(merged_to_current_bytes_ratio < 0.3 && current_bytes_transferred > 1024);
if (!allow_expensive_ops &&
absl::c_any_of(fusion->fused_instructions(),
[](const HloInstruction* instruction) {
return instruction->opcode() != HloOpcode::kParameter &&
GpuInstructionFusion::IsExpensive(*instruction);
})) {
VLOG(3) << "Not merging " << fusion->name()
<< ": Contains one or more expensive instructions.";
++num_fail_expensive_fused_instruction_;
return Status::OK();
}
// Skip 'fusion' instruction if merging it into at least one of the users
// would cause too much code duplication because of inefficiencies in the
// fusion emitter.
// TODO(b/119692968): Remove this once the fusion emitter can handle arbitrary
// fusion nodes.
if (absl::c_any_of(fusion->users(), [fusion](const HloInstruction* user) {
return FusedIrEmitter::IsFusedIrEmitterInefficient(/*consumer=*/user,
/*producer=*/fusion);
})) {
VLOG(3) << "Not merging " << fusion->name()
<< ": Contains one or more users where fusing would cause "
"inefficiencies in the fusion emitter.";
++num_fail_inefficient_fusion_emitter_;
return Status::OK();
}
// Skip 'fusion' instruction if merging it into at least one of the users
// would make the fusion too big.
if (absl::c_any_of(fusion->users(), [fusion](const HloInstruction* user) {
return FusionWouldBeTooLarge(*fusion, *user);
})) {
VLOG(3) << "Not merging " << fusion->name()
<< ": Contains one or more users where fusing would cause "
"the fusion to have too many parameters.";
++num_fail_fusion_too_large_;
return Status::OK();
}
// Merge fused instructions from 'fusion' into each user.
std::vector<HloInstruction*> users = fusion->users();
for (HloInstruction* user : users) {
if (user->opcode() == HloOpcode::kFusion) {
user->MergeFusionInstruction(fusion);
} else {
HloInstruction* fused_user =
computation_->AddInstruction(HloInstruction::CreateFusion(
user->shape(), ChooseFusionKind(*fusion, *user), user));
TF_CHECK_OK(computation_->ReplaceInstruction(user, fused_user));
fused_user->MergeFusionInstruction(fusion);
}
changed_ = true;
}
++total_merged_;
VLOG(2) << "Merged fusion instruction: " << fusion->name()
<< " merged_to_current_bytes_ratio: " << merged_to_current_bytes_ratio
<< " into users { "
<< absl::StrJoin(users, ", ",
[](string* out, HloInstruction* user) {
absl::StrAppend(out, user->name());
})
<< " }";
// Remove 'fusion' instruction.
CHECK_EQ(0, fusion->user_count()) << fusion->ToString();
return computation_->RemoveInstruction(fusion);
}
StatusOr<bool> FusionMerger::Run(HloModule* module) {
bool changed = false;
VLOG(2) << "FusionMerger for module: " << module->name();
for (auto* computation : module->MakeNonfusionComputations()) {
VLOG(1) << "Before running FusionInstructionMerger for computation: "
<< computation->name();
XLA_VLOG_LINES(3, computation->ToString());
FusionInstructionMerger fusion_merger(computation);
TF_RETURN_IF_ERROR(fusion_merger.Run());
changed |= fusion_merger.changed();
VLOG(1) << "After running FusionInstructionMerger for computation: "
<< computation->name() << " changed: " << changed;
XLA_VLOG_LINES(3, computation->ToString());
}
return changed;
}
} // namespace gpu
} // namespace xla