## TFSA-2020-024: Memory leak in `dlpack.to_dlpack` ### CVE Number CVE-2020-15192 ### Impact If a user passes a list of strings to `dlpack.to_dlpack` there is a memory leak following an expected [validation failure](https://github.com/tensorflow/tensorflow/blob/0e68f4d3295eb0281a517c3662f6698992b7b2cf/tensorflow/c/eager/dlpack.cc#L100-L104): ```cc status->status = tensorflow::errors::InvalidArgument( DataType_Name(static_cast<DataType>(data_type)), " is not supported by dlpack"); ``` The allocated memory is [from](https://github.com/tensorflow/tensorflow/blob/0e68f4d3295eb0281a517c3662f6698992b7b2cf/tensorflow/c/eager/dlpack.cc#L256): ```cc auto* tf_dlm_tensor_ctx = new TfDlManagedTensorCtx(tensor_ref); ``` The issue occurs because the `status` argument during validation failures [is not properly checked](https://github.com/tensorflow/tensorflow/blob/0e68f4d3295eb0281a517c3662f6698992b7b2cf/tensorflow/c/eager/dlpack.cc#L265-L267): ```cc dlm_tensor->dl_tensor.data = TFE_TensorHandleDevicePointer(h, status); dlm_tensor->dl_tensor.dtype = GetDlDataType(data_type, status); ``` Since each of the above methods can return an error status, the `status` value must be checked before continuing. ### Vulnerable Versions TensorFlow 2.2.0, 2.3.0. ### Patches We have patched the issue in [22e07fb204386768e5bcbea563641ea11f96ceb8](https://github.com/tensorflow/tensorflow/commit/22e07fb204386768e5bcbea563641ea11f96ceb8) and will release a patch release for all affected versions. We recommend users to upgrade to TensorFlow 2.2.1 or 2.3.1. ### For more information Please consult [our security guide](https://github.com/tensorflow/tensorflow/blob/master/SECURITY.md) for more information regarding the security model and how to contact us with issues and questions. ### Attribution This vulnerability has been discovered through a variant analysis of [a vulnerability reported by members of the Aivul Team from Qihoo 360](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/security/advisory/tfsa-2020-023.md).