[Normal build for Python 3.7]
$ PYTHON=python3.7 tensorflow/lite/tools/pip_package/build_pip_package_with_cmake.sh
[armhf cross build for Python 3.7]
$ tensorflow/tools/ci_build/ci_build.sh PI-PYTHON37 tensorflow/lite/tools/pip_package/build_pip_package_with_cmake.sh armhf
- lite/tools/cmake/download_toolchains.sh is added to download ARM toolchains
- tools/ci_build/Dockerfile.pi* are updated to use cmake 3.16.8
PiperOrigin-RevId: 356621208
Change-Id: I7f1cb0c8389b5a5e637036b52b33e5da0afa2b77
This commit is in reponse to the reviewer feedback for PR https://github.com/tensorflow/tensorflow/pull/46691
Instead of updating to work correctly with Python2.x (i.e. what the PR is currently trying to do), this commit removes all Python2.x references from it (since TF stopped supporting Python2.x a while ago). This should also serve the orignial purpose of unblocking ROCm CI builds.
Having `--force-reinstall` brings in `numpy-1.20` which has a backwards incompatible change. This is a stop gap to fix broken builds but we should convert to installing from a requirements file instead of expliclty listing dependencies (in 6 different places!!!!!)
Also, update estimator to the latest release. It seems we forgot this step after last release.
PiperOrigin-RevId: 355173614
Change-Id: Ia5b235d3df34631a80dcae9b4a101fdd17575295
The TFLM CI is currently failing with the following error message:
```
The following packages have unmet dependencies:
clang : Depends: clang-12 (>= 12~) but it is not installable
clang-format : Depends: clang-format-12 (>= 12~) but it is not installable
E: Unable to correct problems, you have held broken packages.
The command '/bin/sh -c apt-get install -y clang clang-format' returned a non-zero code: 100
```
This changes ensures that we download a specific version of clang. We can still
upgrade if there is a new release, but that should be deliberate instead of
breaking the CI.
PiperOrigin-RevId: 354953821
Change-Id: I693ffef2975a116ffac8f27c409cd5ca7f527790
Currently ROCm TF cotnainers use the `install_pip_packages.sh` script to install the Python pip package-manager.
* https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/Dockerfile.rocm#L102
* https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/ci_build/install/install_pip_packages.sh#L20-L23
Starting 01/23/2021, we started getting the following error while building TF containers for ROCM CI (when calling `get-pip.py` for Python2)
```
Traceback (most recent call last):
File "get-pip.py", line 24226, in <module>
main()
File "get-pip.py", line 199, in main
bootstrap(tmpdir=tmpdir)
File "get-pip.py", line 82, in bootstrap
from pip._internal.cli.main import main as pip_entry_point
File "/tmp/tmpWkL0gn/pip.zip/pip/_internal/cli/main.py", line 60
sys.stderr.write(f"ERROR: {exc}")
```
The cause seems to be an update to the `get-pip.py` script, which now picks the version `pip-21.0` (previously it was `pip-20.3.4`).
`pip-21.0` drops support for Python2.7 (as indicated by the following warning message)
```
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020.
Please upgrade your Python as Python 2.7 is no longer maintained.
pip 21.0 will drop support for Python 2.7 in January 2021.
More details about Python 2 support in pip can be found at
https://pip.pypa.io/en/latest/development/release-process/#python-2-support
pip 21.0 will remove support for this functionality.
```
It seems that there is now a Python 2.7 specific version of the `get-pip.py` script that we need to use, and that is what this commit does
It currently attempts to use python3.5. So build breaks.
Should fully unblock #46075
PiperOrigin-RevId: 353753493
Change-Id: Iab2d204d8b6ff299942a8748f53d1cee46cb65a8
Will update to newer version later, after testing that this works and only if needed. Might be rolled back if continuous builds fail after merging.
Added a lot of errors to allow-list, will organize fix-it to remove them.
Removes the `W9015:missing-param-doc` warning type added in #45427 as TF is not ready for that yet.
Part of the work for #46046, #43040. Unblocks #46075
PiperOrigin-RevId: 353741692
Change-Id: I542e3f28253afada12b595863e571c058f7228b9
Speed up from 177s to 152s.
Remove loop that was checking each error individually against allowlist regexps one by one. This is slow and also results in the same line being reported multiple times (e.g., for a total of 254 pylint reports, there are 1356 matches printed).
Furthermore, loop seems to have matched real errors against the approved list (because it takes regexps as words, not as lines! -- see below), thus allowing linting errors to pass through. Fixing them in this change too.
```
Found an allowlisted error:
tensorflow/security/fuzzing/raggedCountSparseOutput_fuzz.py:36: [C0330(bad-continuation), ] Wrong hanging indentation (remove 6 spaces).
via space
^^^^^ (this is a word in a allowlist line, taken as a regexp to match)
```
Display proper statistics about the errors at the end of the step.
Part of the work for #46046, #43040. Unblocks #46075
PiperOrigin-RevId: 353679614
Change-Id: I0de07755e754364dc34f4fd1575e4dc59233cdec
This is the same as used internally. Will update to newer version later, after testing that this works and only if needed. Might be rolled back if continuous builds fail after merging.
Part of the work for #46046, #43040. Unblocks #46075
PiperOrigin-RevId: 353132925
Change-Id: I82388ca6b92cc5d903d04e538e4ffa6dbcabe34e
This is the same as used internally. Will update to newer version later, after testing that this works and only if needed. Might be rolled back if continuous builds fail after merging.
Part of the work for #46046, #43040. Unblocks #46075
PiperOrigin-RevId: 353119640
Change-Id: Iabdf9822fcc2e2e1d788b533bcba21a0183d1131
We already deprecated them, so they should no longer be used at all. We have CI failing as it picks a py3.5 default. Subsequent changes will fix broken CI jobs.
PiperOrigin-RevId: 352044870
Change-Id: I50a62d322ec05781beea78a27704ee7849c277e1
Since caller scripts use Bazelisk, the docker job is broken if we want to use a bazel that is no longer the default one.
PiperOrigin-RevId: 351891433
Change-Id: I6caf0b5940934a3a90737f7fae288c42953a23f1
