Commit Graph

7 Commits

Author SHA1 Message Date
Deven Desai
da8326db56 Adding rocsolver to the local_config_rocm repo 2020-12-10 18:43:26 +00:00
Adrian Kuegel
3a52a5462c Don't overwrite path variable.
We still need the old value in the second iteration of the for loop.

PiperOrigin-RevId: 345395449
Change-Id: I752cdb9895861ce7cbc30b6ad34f6ffaac60c761
2020-12-03 00:30:29 -08:00
Adrian Kuegel
3ec134727f Small improvements to find_rocm_config.py
Also update the corresponding compressed file.
Also comment out the lines which try to find configs which do not
work. The currently used compressed file also has these commented out.

PiperOrigin-RevId: 344387253
Change-Id: I880642a483b332ab97cdc96fe42379e131121d74
2020-11-26 02:14:51 -08:00
TensorFlower Gardener
c9b9127fb3 Merge pull request from ROCmSoftwarePlatform:google_upstream_rocm_misc_updates_201124
PiperOrigin-RevId: 344211203
Change-Id: I269866da3d130137209edc1b488e5fd1330895ef
2020-11-25 01:54:28 -08:00
Deven Desai
4fb2794bb9 Updating find_rocm_config.py to pickup the commit that was missed when merging PR ( https://github.com/tensorflow/tensorflow/pull/44471 )
See the following comments (in PR # 44471 for further details)
https://github.com/tensorflow/tensorflow/pull/44471#issuecomment-724678159
https://github.com/tensorflow/tensorflow/pull/44471#issuecomment-724729560
2020-11-24 15:03:38 +00:00
TensorFlower Gardener
cd24d4b345 Merge pull request from ROCmSoftwarePlatform:google_upstream_rocm_version_defines
PiperOrigin-RevId: 341361119
Change-Id: I7c52235336cd81aeab3e20e60b1e9356c520b36b
2020-11-09 01:53:36 -08:00
Deven Desai
0b793fecd1 Adding #defines for ROCm / MIOpen / HIP Runtime version numbers
This PR/commit introduces the following #defines in the `rocm/rocm_config.h` file

```
#define TF_ROCM_VERSION <Version Number of ROCm install>
#define TF_MIOPEN_VERSION <Verion Number of MIOpen in ROCm install>
#define TF_HIPRUNTIME_VERSION <Version Number of HIP Runtinme in ROCm install>
```

These #defines should be used within TF code to add ROCm/MIOpen/HIp Runtime version specific code.

Details on how we go about determining these version numbers can found on the following wiki-page

https://github.com/ROCmSoftwarePlatform/tensorflow-internal/wiki/How-to-add-ROCm-version-specific-code-changes-in-the-TensorFlow-code%3F

A new script `find_rocm_config.py` is being added by this commit. This script does all the work of determining the version number information and it is pretty to extend it to query more information about the ROCM install.

The information collected by the script is available to `rocm_configure.bzl` and hence can be used to add version specific code in `rocm_configure.bzl` as well.
2020-11-05 13:18:23 +00:00