The test was disabled in a variety of places due to multiprocessing being
flaky, so this seemed like an improvement.
PiperOrigin-RevId: 305360413
Change-Id: I5e383bebec23c8546d1b58cd7524e020d975591b
If pybind11 is installed on the system its headers are already captured
by @local_config_python//:python_headers, so the system lib only needs
to depend on that.
When installed correctly, includes should be #include "pybind11/...",
the bundled pybind11 is based off the source repo which does not match
the install paths. Use bazels strip_include_prefix to align the bundled
headers correctly.
Signed-off-by: Jason Zaman <jason@perfinion.com>
After 5659465166, `GetMatchingPaths` was converted to use RE2 instead of `fnmatch` as that allows non-local filesystems (e.g., GCS, Hadoop, S3) to also be used from Windows. However, this breaks compatibility between `tf.io.gfile.glob` and Python `glob` and that results in tests silently failing or examples being silently skipped during training.
The fix is two-pronged. First, to fix#37758 only, we add regexp replacements for `(` and `)` in the pattern, escaping them before matching. After testing and seeing that this works, we then re-enable `fnmatch` on POSIX environments to reduce binary size, just like we did for mobile platforms.
Fixes#37758 (everywhere) and tensorflow/tensorboard#3260 (on posix platforms).
Tested via `bazel run //tensorflow/python:file_io_test` after adding a test for the pattern in #37758.
Will need to be cherry-picked onto `r2.2` branch.
PiperOrigin-RevId: 303009914
Change-Id: Ieab047f63e9ba6bb0ec0499e0fa864f6ca6090ff
Address feedback
Add test for the python method has_atomic_move
Removed old comment, and fixed indentation
Remove unncessary imports
Remove the test which checks for reference cycles when saving. Since the check for file system introduces a conditional op, it introduces a reference cycle, and this check does not apply anymore
Fighting lint
Fix lint errors
Use returned status of hasAtomicMove
TensorBoard now uses tf_record_iterator and relies on new aspects of its behavior (preserving the read offset when encountering EOF or a data loss error, rather than closing the reader) to "poll" event files that get appended with new data during training, without having to reread the file from the beginning. To help prevent regressions that would break TensorBoard, this CL adds tests to verify that behavior.
PiperOrigin-RevId: 292066760
Change-Id: Ie15e055e30aa55398ff0dab3ae54f42e616d80a2
Motivation:
- tfdbg2 needs to access tfrecord files (holding DebugEvent protos) at random offsets.
- However, tf_record.tf_record_iterator (implemented based on pybind11) doesn't support reading from random offsets.
Implementation description:
- Add new factory function in tf_record.py: tf_record_random_reader()
- The support is made available only for uncompressed tf_record file iterators.
PiperOrigin-RevId: 287832909
Change-Id: Icf08ef2d0091bdf191bc218a6e7eabd6e5c3f854
This is part of a larger effort to deprecate swig and eventually with
modularization break pywrap_tensorflow into smaller components.
Please refer to https://github.com/tensorflow/community/blob/master/rfcs/20190208-pybind11.md
for more information.
PiperOrigin-RevId: 286474536
Change-Id: Ic942a4480b1c1a19bdc3d6b65d3272221e47537b
This is mostly the result of an internal cleanup and formatting pass.
PiperOrigin-RevId: 286318018
Change-Id: I8f9e2f7519070035da73f9f24d2fc90864abc51b
This is part of a larger effort to deprecate swig and eventually with
modularization break pywrap_tensorflow into smaller components.
Please refer to https://github.com/tensorflow/community/blob/master/rfcs/20190208-pybind11.md
for more information.
PiperOrigin-RevId: 286302183
Change-Id: I4baf4a2628d46d7bdf3aa2916fb6f980a3c99abe
This is part of a larger effort to deprecate swig and eventually with
modularization break pywrap_tensorflow into smaller components.
Please refer to https://github.com/tensorflow/community/blob/master/rfcs/20190208-pybind11.md
for more information.
PiperOrigin-RevId: 286188001
Change-Id: Iebdc4335de88bc9e42267e68e28e0d7a9e840b9f
This is part of a larger effort to deprecate swig and eventually with
modularization break pywrap_tensorflow into smaller components.
Please refer to https://github.com/tensorflow/community/blob/master/rfcs/20190208-pybind11.md
for more information.
PiperOrigin-RevId: 286181704
Change-Id: I06e92ec7bc945c4efd69de85ef8b9e4de8007bf4
Note that prior to this change lack of %unignoreall was compensated by
the ordering of includes.
PiperOrigin-RevId: 280669839
Change-Id: I5147c09bfa294ffcf4337077f8ef337efa1cd971
