experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[Graph] Avoid copying the NodeDef where possible in Node::UpdateProperties().

Browse Source 
1. We currently only call `UpdateProperties()` from `AddAttr()`, which ensures that we have unique ownership of the shared `NodeProperties`. This allows us to modify the `NodeProperties` in place.
2. We only need to update the `NodeProperties` when the input and output types change as a result of adding the new attr. Most calls to `AddAttr()` add inferred shape attributes, and do not modify the input or output types.

PiperOrigin-RevId: 307054556
Change-Id: I01fbc6ba832020bcd2d89822a5d3a2e3beba02ce
This commit is contained in:
Derek Murray 2020-04-17 09:09:29 -07:00 committed by TensorFlower Gardener
parent 9344756185
commit f7bae45c69
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tensorflow/core/graph/graph.cc
View File

@ -156,8 +156,17 @@ void Node::UpdateProperties() {
LOG(ERROR) << "Failed at updating node: " << status;
return;
}
props_ = std::make_shared<NodeProperties>(props_->op_def, props_->node_def,
inputs, outputs);
if (props_->input_types != inputs || props_->output_types != outputs) {
if (TF_PREDICT_TRUE(props_.use_count() == 1)) {
props_->input_types = inputs;
props_->input_types_slice = props_->input_types;
props_->output_types = outputs;
props_->output_types_slice = props_->output_types;
} else {
props_ = std::make_shared<NodeProperties>(
props_->op_def, std::move(props_->node_def), inputs, outputs);
}
}
}
const string& Node::name() const { return props_->node_def.name(); }