experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update a comment why terimnate op should be skipped in While op

Browse Source 
canonicalization

PiperOrigin-RevId: 351878286
Change-Id: I42707904a8b188e2f64a7bb3825322b44f13d1cc
This commit is contained in:
Jaesung Chung 2021-01-14 14:32:46 -08:00 committed by TensorFlower Gardener
parent 51d0e14e15
commit e97de5bfd7
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tensorflow/compiler/mlir/lite/ir/tfl_ops.cc
View File

@ -2487,7 +2487,10 @@ struct WhileResultOperandsMatchAndImplicitCapture
if (getElementTypeOrSelf(ba.getType()).isa<TF::ResourceType>()) {
bool has_read_only_variables = true;
for (auto user : ba.getUsers()) {
// Ternimator ops, for example, tfl::yield op, should be ignored.
// Ternimator ops, for example, tfl::yield op, should be ignored since
// the argument can be used for yielding as the `body` function result
// and that does not give any meaningful points to the decision
// whether the given arugment is a read-only variable or not.
if (user->hasTrait<OpTrait::IsTerminator>()) continue;
if (!llvm::isa<mlir::TF::ReadVariableOp>(user)) {
has_read_only_variables = false;