Use Env::LocalTempFilename for a temp filename.
This function works both in and outside of tests. Additionally, LocalTempFilename works well on Windows where as TmpDir is a little problematic because of bazel oddities. PiperOrigin-RevId: 296251680 Change-Id: I985f178e2e85105cf79c4572b9158e168490348c
This commit is contained in:
parent
eaedb464a0
commit
e972858a29
@ -63,7 +63,8 @@ typedef io::ZlibCompressionOptions CompressionOptions;
|
||||
void TestAllCombinations(CompressionOptions input_options,
|
||||
CompressionOptions output_options) {
|
||||
Env* env = Env::Default();
|
||||
string fname = testing::TmpDir() + "/zlib_buffers_test";
|
||||
string fname;
|
||||
ASSERT_TRUE(env->LocalTempFilename(&fname));
|
||||
for (auto file_size : NumCopies()) {
|
||||
// Write to compressed file
|
||||
string data = GenTestString(file_size);
|
||||
@ -114,7 +115,8 @@ void TestMultipleWrites(uint8 input_buf_size, uint8 output_buf_size,
|
||||
CompressionOptions input_options = CompressionOptions::DEFAULT();
|
||||
CompressionOptions output_options = CompressionOptions::DEFAULT();
|
||||
|
||||
string fname = testing::TmpDir() + "/zlib_buffers_test";
|
||||
string fname;
|
||||
ASSERT_TRUE(env->LocalTempFilename(&fname));
|
||||
string data = GenTestString();
|
||||
std::unique_ptr<WritableFile> file_writer;
|
||||
string actual_result;
|
||||
@ -162,7 +164,8 @@ TEST(ZlibBuffers, MultipleWriteCallsWithFlush) {
|
||||
|
||||
TEST(ZlibInputStream, FailsToReadIfWindowBitsAreIncompatible) {
|
||||
Env* env = Env::Default();
|
||||
string fname = testing::TmpDir() + "/zlib_buffers_test";
|
||||
string fname;
|
||||
ASSERT_TRUE(env->LocalTempFilename(&fname));
|
||||
CompressionOptions output_options = CompressionOptions::DEFAULT();
|
||||
CompressionOptions input_options = CompressionOptions::DEFAULT();
|
||||
int input_buf_size = 200, output_buf_size = 200;
|
||||
@ -214,7 +217,8 @@ void WriteCompressedFile(Env* env, const string& fname, int input_buf_size,
|
||||
void TestTell(CompressionOptions input_options,
|
||||
CompressionOptions output_options) {
|
||||
Env* env = Env::Default();
|
||||
string fname = testing::TmpDir() + "/zlib_buffers_test";
|
||||
string fname;
|
||||
ASSERT_TRUE(env->LocalTempFilename(&fname));
|
||||
for (auto file_size : NumCopies()) {
|
||||
string data = GenTestString(file_size);
|
||||
for (auto input_buf_size : InputBufferSizes()) {
|
||||
@ -258,7 +262,8 @@ void TestTell(CompressionOptions input_options,
|
||||
void TestSkipNBytes(CompressionOptions input_options,
|
||||
CompressionOptions output_options) {
|
||||
Env* env = Env::Default();
|
||||
string fname = testing::TmpDir() + "/zlib_buffers_test";
|
||||
string fname;
|
||||
ASSERT_TRUE(env->LocalTempFilename(&fname));
|
||||
for (auto file_size : NumCopies()) {
|
||||
string data = GenTestString(file_size);
|
||||
for (auto input_buf_size : InputBufferSizes()) {
|
||||
@ -296,7 +301,8 @@ void TestSkipNBytes(CompressionOptions input_options,
|
||||
|
||||
void TestSoftErrorOnDecompress(CompressionOptions input_options) {
|
||||
Env* env = Env::Default();
|
||||
string fname = testing::TmpDir() + "/garbage_data";
|
||||
string fname;
|
||||
ASSERT_TRUE(env->LocalTempFilename(&fname));
|
||||
|
||||
input_options.soft_fail_on_error = true;
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user