Update following the comments. Also update the description.

This commit is contained in:
Frederic Bastien 2020-06-09 14:22:10 -07:00
parent 3946ad2bfd
commit e830f70d70
3 changed files with 8 additions and 7 deletions

View File

@ -37,7 +37,7 @@ DebugOptions DefaultDebugOptionsIgnoringFlags() {
opts.set_xla_gpu_autotune_level(4);
opts.set_xla_cpu_multi_thread_eigen(true);
opts.set_xla_gpu_cuda_data_dir("./cuda_sdk_lib");
opts.set_xla_gpu_gpuasm_extra_flags("");
opts.set_xla_gpu_asm_extra_flags("");
opts.set_xla_eliminate_hlo_implicit_broadcast(true);
opts.set_xla_dump_hlo_as_html(false);
opts.set_xla_dump_include_timestamp(true);
@ -432,9 +432,10 @@ static void AllocateFlags() {
flag_values->xla_gpu_disable_gpuasm_optimizations(),
"In XLA:GPU run ptxas in -O0 (default is -O3)."));
flag_objects->push_back(tensorflow::Flag(
"xla_gpu_gpuasm_extra_flags", string_setter_for(&DebugOptions::set_xla_gpu_gpuasm_extra_flags),
"", //flag_values->xla_gpu_gpuasm_extra_flags(),
"Pass extra parameters to the GPU assembler tool (i.e., ptxas for CUDA)."));
"xla_gpu_asm_extra_flags", string_setter_for(&DebugOptions::set_xla_gpu_asm_extra_flags),
"",
"Pass extra parameters to the GPU assembler tool (i.e., ptxas for CUDA). "
"If multiple parameters, separate them by comma."));
flag_objects->push_back(tensorflow::Flag(
"xla_fuel", setter_for_xla_fuel, /*default_value_for_display=*/"",
"Sets compiler fuel, useful for bisecting bugs in passes. Format "

View File

@ -222,9 +222,9 @@ Status ExecuteKernelOnStream(const se::KernelBase& kernel,
}
se::GpuAsmOpts PtxOptsFromConfig(const HloModuleConfig& hlo_module_config) {
string extra_string = hlo_module_config.debug_options().xla_gpu_gpuasm_extra_flags();
string extra_string = hlo_module_config.debug_options().xla_gpu_asm_extra_flags();
std::vector<std::string> extra_flags;
extra_flags = absl::StrSplit(extra_string, " ", absl::SkipEmpty());
extra_flags = absl::StrSplit(extra_string, ",", absl::SkipEmpty());
return se::GpuAsmOpts(
hlo_module_config.debug_options().xla_gpu_disable_gpuasm_optimizations(),
hlo_module_config.debug_options().xla_gpu_cuda_data_dir(),

View File

@ -288,7 +288,7 @@ message DebugOptions {
bool xla_gpu_unsafe_fallback_to_driver_on_ptxas_not_found = 138;
// Extra parameters to pass the GPU assembler.
string xla_gpu_gpuasm_extra_flags = 141;
string xla_gpu_asm_extra_flags = 141;
// Next id: 142