From e5678b1560d068ad156fa3b8096bfa5aa5243b94 Mon Sep 17 00:00:00 2001 From: Jiri Simsa Date: Wed, 22 May 2019 14:17:32 -0700 Subject: [PATCH] [tf.data] Reducing tracing overhead. PiperOrigin-RevId: 249518292 --- .../kernels/data/experimental/map_and_batch_dataset_op.cc | 8 +++----- .../core/kernels/data/parallel_interleave_dataset_op.cc | 8 +++----- tensorflow/core/kernels/data/parallel_map_iterator.cc | 8 +++----- 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/tensorflow/core/kernels/data/experimental/map_and_batch_dataset_op.cc b/tensorflow/core/kernels/data/experimental/map_and_batch_dataset_op.cc index a7472a49e4a..f0c0096c7e5 100644 --- a/tensorflow/core/kernels/data/experimental/map_and_batch_dataset_op.cc +++ b/tensorflow/core/kernels/data/experimental/map_and_batch_dataset_op.cc @@ -208,11 +208,9 @@ class MapAndBatchDatasetOp : public UnaryDatasetOpKernel { } string BuildTraceMeName() override { - int64 parallelism; - { - tf_shared_lock l(*mu_); - parallelism = num_parallel_calls_->value; - } + // NOTE: We do not synchronize the following access to + // num_parallel_calls_ to minimize the tracing overhead. + int64 parallelism = num_parallel_calls_->value; return strings::StrCat(prefix(), "#parallelism=", parallelism, "#"); } diff --git a/tensorflow/core/kernels/data/parallel_interleave_dataset_op.cc b/tensorflow/core/kernels/data/parallel_interleave_dataset_op.cc index 835b2387c1e..1a09e33cad8 100644 --- a/tensorflow/core/kernels/data/parallel_interleave_dataset_op.cc +++ b/tensorflow/core/kernels/data/parallel_interleave_dataset_op.cc @@ -213,11 +213,9 @@ class ParallelInterleaveDatasetOp : public UnaryDatasetOpKernel { } string BuildTraceMeName() override { - int64 parallelism; - { - tf_shared_lock l(*mu_); - parallelism = num_parallel_calls_->value; - } + // NOTE: We do not synchronize the following access to + // num_parallel_calls_ to minimize the tracing overhead. + int64 parallelism = num_parallel_calls_->value; return strings::StrCat(prefix(), "#parallelism=", parallelism, "#"); } diff --git a/tensorflow/core/kernels/data/parallel_map_iterator.cc b/tensorflow/core/kernels/data/parallel_map_iterator.cc index 52befecb12e..52be8793c67 100644 --- a/tensorflow/core/kernels/data/parallel_map_iterator.cc +++ b/tensorflow/core/kernels/data/parallel_map_iterator.cc @@ -74,11 +74,9 @@ class ParallelMapIterator : public DatasetBaseIterator { } string BuildTraceMeName() override { - int64 parallelism; - { - tf_shared_lock l(*mu_); - parallelism = num_parallel_calls_->value; - } + // NOTE: We do not synchronize the following access to num_parallel_calls_ + // to minimize the tracing overhead. + int64 parallelism = num_parallel_calls_->value; return strings::StrCat(prefix(), "#parallelism=", parallelism, "#"); }