From e323dc9a05193c76ba5db1c71d0ef019be676224 Mon Sep 17 00:00:00 2001 From: Tres Popp Date: Fri, 29 Jan 2021 02:13:07 -0800 Subject: [PATCH] Change division tests to use assertAllClose Floating point operations do not guarantee bit for bit equality between different implementations, so just confirm that it's very close. PiperOrigin-RevId: 354493959 Change-Id: Ic66e4f55322e65f5381bf25cebb56ec3b609b9ca --- tensorflow/python/kernel_tests/division_future_test.py | 2 +- tensorflow/python/kernel_tests/division_past_test.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tensorflow/python/kernel_tests/division_future_test.py b/tensorflow/python/kernel_tests/division_future_test.py index 85c85809d3f..b0a5d8c7211 100644 --- a/tensorflow/python/kernel_tests/division_future_test.py +++ b/tensorflow/python/kernel_tests/division_future_test.py @@ -47,7 +47,7 @@ class DivisionTestCase(test.TestCase): tensors.append((x, y)) def f(x, y): self.assertEqual(x.dtype, y.dtype) - self.assertEqual(x, y) + self.assertAllClose(x, y) checks.append(f) with self.cached_session() as sess: diff --git a/tensorflow/python/kernel_tests/division_past_test.py b/tensorflow/python/kernel_tests/division_past_test.py index 38bb18631ab..7701edfa1b5 100644 --- a/tensorflow/python/kernel_tests/division_past_test.py +++ b/tensorflow/python/kernel_tests/division_past_test.py @@ -14,7 +14,7 @@ # ============================================================================== """Tests for division with division imported from __future__. -This file should be exactly the same as division_past_test.py except +This file should be exactly the same as division_future_test.py except for the __future__ division line. """ @@ -46,7 +46,7 @@ class DivisionTestCase(test.TestCase): tensors.append((x, y)) def f(x, y): self.assertEqual(x.dtype, y.dtype) - self.assertEqual(x, y) + self.assertAllClose(x, y) checks.append(f) with self.cached_session() as sess: