Deprecate broadcast-replicated-params option in xla::ExecutionOptions proto.

PiperOrigin-RevId: 358240599
Change-Id: I6c7ee0d23500ab0072fcb3f5b3bab71d2349a3f8
This commit is contained in:
Tayo Oguntebi 2021-02-18 12:39:40 -08:00 committed by TensorFlower Gardener
parent c7f4c10250
commit dfc6473f5d
6 changed files with 1 additions and 21 deletions

View File

@ -83,12 +83,6 @@ ExecutableBuildOptions& ExecutableBuildOptions::set_deduplicate_hlo(
return *this;
}
ExecutableBuildOptions& ExecutableBuildOptions::set_broadcast_replicated_params(
bool broadcast_replicated_params) {
broadcast_replicated_params_ = broadcast_replicated_params;
return *this;
}
ExecutableBuildOptions& ExecutableBuildOptions::set_device_assignment(
const DeviceAssignment& device_assignment) {
device_assignment_ = device_assignment;

View File

@ -92,12 +92,6 @@ class ExecutableBuildOptions {
bool deduplicate_hlo() const { return deduplicate_hlo_; }
ExecutableBuildOptions& set_deduplicate_hlo(bool deduplicate_hlo);
bool broadcast_replicated_params() const {
return broadcast_replicated_params_;
}
ExecutableBuildOptions& set_broadcast_replicated_params(
bool broadcast_replicated_params);
// If set, this specifies a static device assignment for the computation.
// Otherwise, the computation will be compiled generically and can be run with
// any device assignment compatible with the computation's replica and

View File

@ -93,8 +93,6 @@ CompileOnlyService::CompileAheadOfTime(
}
execution_options.set_use_spmd_partitioning(options.use_spmd_partitioning());
execution_options.set_deduplicate_hlo(options.deduplicate_hlo());
execution_options.set_broadcast_replicated_parameters_via_collectives(
options.broadcast_replicated_params());
for (const AotXlaComputationInstance& instance : computations) {
TF_RET_CHECK(instance.computation.has_host_program_shape());
*execution_options.mutable_shape_with_output_layout() =

View File

@ -447,8 +447,6 @@ StatusOr<HloModuleConfig> HloModule::CreateModuleConfigFromShape(
module_config.set_use_spmd_partitioning(
execution_options->use_spmd_partitioning());
module_config.set_deduplicate_hlo(execution_options->deduplicate_hlo());
module_config.set_broadcast_replicated_params(
execution_options->broadcast_replicated_parameters_via_collectives());
if (execution_options->has_device_assignment()) {
TF_ASSIGN_OR_RETURN(std::unique_ptr<DeviceAssignment> device_assignment,
DeviceAssignment::Deserialize(

View File

@ -96,8 +96,6 @@ StatusOr<std::unique_ptr<HloModuleConfig>> CreateModuleConfig(
config->set_use_spmd_partitioning(
execution_options->use_spmd_partitioning());
config->set_deduplicate_hlo(execution_options->deduplicate_hlo());
config->set_broadcast_replicated_params(
execution_options->broadcast_replicated_parameters_via_collectives());
config->set_seed(execution_options->seed());
config->set_launch_id(execution_options->launch_id());
config->set_debug_options(execution_options->debug_options());

View File

@ -378,9 +378,7 @@ message ExecutionOptions {
// works on TPU.
bool deduplicate_hlo = 12;
// If set, broadcast replicated parameters to all replicas, using collectives.
// Only applicable to TPU.
bool broadcast_replicated_parameters_via_collectives = 13;
reserved 13; // Was broadcast_replicated_parameters_via_collectives = 13;
}
message GetDeviceHandlesRequest {