experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use std::forward_list for fast destruction

Browse Source 
Helps avoid constructing the vector which is usually not used.

PiperOrigin-RevId: 281325666
Change-Id: Ie7bd6ec72412245de590b75a76c3c22b00650bd0
This commit is contained in:
Gaurav Jain 2019-11-19 10:33:41 -08:00 committed by TensorFlower Gardener
parent a6ceaa8440
commit ddbdb4a7fd
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
tensorflow/core/common_runtime/eager/eager_executor.cc
View File

@ -15,6 +15,8 @@ limitations under the License.
#include "tensorflow/core/common_runtime/eager/eager_executor.h" #include "tensorflow/core/common_runtime/eager/eager_executor.h"
#include <forward_list>
#include "tensorflow/core/lib/core/errors.h" #include "tensorflow/core/lib/core/errors.h"
#include "tensorflow/core/lib/gtl/cleanup.h" #include "tensorflow/core/lib/gtl/cleanup.h"
@ -175,13 +177,13 @@ void EagerExecutor::NodeDone(const core::RefCountPtr<NodeItem>& item,
const Status& status) { const Status& status) {
DVLOG(3) << "Node Done: [id " << item->id << "] " << item->node->DebugString() DVLOG(3) << "Node Done: [id " << item->id << "] " << item->node->DebugString()
<< " with status: " << status.ToString(); << " with status: " << status.ToString();
std::vector<core::RefCountPtr<NodeItem>> items_to_destroy; DCHECK(item->state != NodeState::kDONE);
{ auto previous_state = item->state;
DCHECK(item->state != NodeState::kDONE); item->state = NodeState::kDONE;
auto previous_state = item->state; if (!ok()) return;
item->state = NodeState::kDONE;
if (!ok()) return;
std::forward_list<core::RefCountPtr<NodeItem>> items_to_destroy;
{
mutex_lock l(node_queue_mutex_); mutex_lock l(node_queue_mutex_);
bool need_notification = false; bool need_notification = false;
if (previous_state == NodeState::kPENDING) { if (previous_state == NodeState::kPENDING) {
@ -210,11 +212,11 @@ void EagerExecutor::NodeDone(const core::RefCountPtr<NodeItem>& item,
"operations and poisons their output tensors."); "operations and poisons their output tensors.");
} }
while (!node_queue_.empty()) { while (!node_queue_.empty()) {
items_to_destroy.push_back(std::move(node_queue_.front())); items_to_destroy.push_front(std::move(node_queue_.front()));
node_queue_.pop(); node_queue_.pop();
} }
for (auto& it : unfinished_nodes_) { for (auto& it : unfinished_nodes_) {
items_to_destroy.push_back(std::move(it.second)); items_to_destroy.push_front(std::move(it.second));
} }
unfinished_nodes_.clear(); unfinished_nodes_.clear();
} }