experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[XLA:Python] Temporarily disable codepath that is causing segfaults.

Browse Source 
PiperOrigin-RevId: 294817127
Change-Id: I4bb4e51fcebc03dd1dae2bcec69205b95ad686ee
This commit is contained in:
Skye Wanderman-Milne 2020-02-12 19:39:24 -08:00 committed by TensorFlower Gardener
parent 73c31e6c97
commit cec24afe2d
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tensorflow/compiler/xla/python/xla.cc
View File

@ -677,15 +677,16 @@ PYBIND11_MODULE(xla_extension, m) {
GlobalPyRefManager()->CollectGarbage();
PyLocalBuffer* buffer = buffer_obj.cast<PyLocalBuffer*>();
LocalDeviceState* state = buffer->device()->local_device_state();
if (state->executor()->platform_kind() == se::PlatformKind::kHost &&
buffer->on_device_shape().IsArray() &&
buffer->on_device_shape().element_type() != BF16) {
py::object out = py::reinterpret_steal<py::object>(
PyArray_FROM_O(buffer_obj.ptr()));
CHECK(out.ptr() != nullptr)
<< buffer->on_host_shape().ToString(/*print_layout=*/true);
return out;
}
// TODO(phawkins): fix occasional segfaults
// if (state->executor()->platform_kind() == se::PlatformKind::kHost
// && buffer->on_device_shape().IsArray() &&
// buffer->on_device_shape().element_type() != BF16) {
// py::object out = py::reinterpret_steal<py::object>(
// PyArray_FROM_O(buffer_obj.ptr()));
// CHECK(out.ptr() != nullptr)
// << buffer->on_host_shape().ToString(/*print_layout=*/true);
// return out;
// }
std::shared_ptr<Literal> literal;
{
py::gil_scoped_release gil_release;