Add test to prevent identity renames in compatibility tools.
We previously had methods being renamed to the same name. This test will prevent a regression. PiperOrigin-RevId: 248153339
This commit is contained in:
parent
ae6df76700
commit
cd611387e4
@ -84,6 +84,7 @@ py_library(
|
|||||||
py_library(
|
py_library(
|
||||||
name = "all_renames_v2",
|
name = "all_renames_v2",
|
||||||
srcs = ["all_renames_v2.py"],
|
srcs = ["all_renames_v2.py"],
|
||||||
|
srcs_version = "PY2AND3",
|
||||||
visibility = [
|
visibility = [
|
||||||
"//tensorflow:__pkg__",
|
"//tensorflow:__pkg__",
|
||||||
"//tensorflow:__subpackages__",
|
"//tensorflow:__subpackages__",
|
||||||
@ -91,6 +92,18 @@ py_library(
|
|||||||
deps = [":renames_v2"],
|
deps = [":renames_v2"],
|
||||||
)
|
)
|
||||||
|
|
||||||
|
py_test(
|
||||||
|
name = "all_renames_v2_test",
|
||||||
|
srcs = ["all_renames_v2_test.py"],
|
||||||
|
srcs_version = "PY2AND3",
|
||||||
|
deps = [
|
||||||
|
":all_renames_v2",
|
||||||
|
"//tensorflow/python:client_testlib",
|
||||||
|
"//tensorflow/python:framework_test_lib",
|
||||||
|
"@six_archive//:six",
|
||||||
|
],
|
||||||
|
)
|
||||||
|
|
||||||
py_library(
|
py_library(
|
||||||
name = "module_deprecations_v2",
|
name = "module_deprecations_v2",
|
||||||
srcs = ["module_deprecations_v2.py"],
|
srcs = ["module_deprecations_v2.py"],
|
||||||
|
40
tensorflow/tools/compatibility/all_renames_v2_test.py
Normal file
40
tensorflow/tools/compatibility/all_renames_v2_test.py
Normal file
@ -0,0 +1,40 @@
|
|||||||
|
# Copyright 2019 The TensorFlow Authors. All Rights Reserved.
|
||||||
|
#
|
||||||
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
# you may not use this file except in compliance with the License.
|
||||||
|
# You may obtain a copy of the License at
|
||||||
|
#
|
||||||
|
# http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
#
|
||||||
|
# Unless required by applicable law or agreed to in writing, software
|
||||||
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
# See the License for the specific language governing permissions and
|
||||||
|
# limitations under the License.
|
||||||
|
# ==============================================================================
|
||||||
|
"""Tests for all_renames_v2."""
|
||||||
|
|
||||||
|
from __future__ import absolute_import
|
||||||
|
from __future__ import division
|
||||||
|
from __future__ import print_function
|
||||||
|
|
||||||
|
import six
|
||||||
|
|
||||||
|
from tensorflow.python.framework import test_util
|
||||||
|
from tensorflow.python.platform import test as test_lib
|
||||||
|
from tensorflow.tools.compatibility import all_renames_v2
|
||||||
|
|
||||||
|
|
||||||
|
class AllRenamesV2Test(test_util.TensorFlowTestCase):
|
||||||
|
|
||||||
|
def test_no_identity_renames(self):
|
||||||
|
identity_renames = [
|
||||||
|
old_name
|
||||||
|
for old_name, new_name in six.iteritems(all_renames_v2.symbol_renames)
|
||||||
|
if old_name == new_name
|
||||||
|
]
|
||||||
|
self.assertEmpty(identity_renames)
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
test_lib.main()
|
Loading…
x
Reference in New Issue
Block a user