experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[mlir][kernelgen] Test ops that can return NaN with the default set of inputs

Browse Source 
NaNs no longer break comparisons, so it's safe to test them now. I also want to
put a NaN into the default set of inputs eventually, but right now that
uncovers some bugs in both Eigen and generated kernels.

PiperOrigin-RevId: 356473399
Change-Id: I2d39f0906ccbcbabb8d0bef48e0d23f6f58da620
This commit is contained in:
Benjamin Kramer 2021-02-09 04:36:43 -08:00 committed by TensorFlower Gardener
parent 8b2448df19
commit cb9da9e776
2 changed files with 42 additions and 78 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
tensorflow/core/kernels/mlir_generated/gpu_binary_ops_test.cc
View File

@ -170,19 +170,13 @@ T baseline_div(T lhs, T rhs) {
return lhs / rhs; return lhs / rhs;
} }
GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TESTS(Div,
Div, /*test_name=*/Half, Eigen::half, Eigen::half,
/*test_name=*/Half, Eigen::half, Eigen::half, baseline_div);
test::DefaultInput<Eigen::half>(), test::DefaultInputNonZero<Eigen::half>(), GENERATE_DEFAULT_TESTS(Div,
baseline_div); /*test_name=*/Float, float, float, baseline_div);
GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TESTS(Div,
Div, /*test_name=*/Double, double, double, baseline_div);
/*test_name=*/Float, float, float, test::DefaultInput<float>(),
test::DefaultInputNonZero<float>(), baseline_div);
GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES(
Div,
/*test_name=*/Double, double, double, test::DefaultInput<double>(),
test::DefaultInputNonZero<double>(), baseline_div);
GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES(
Div, Div,
/*test_name=*/Int16, int16, int16, test::DefaultInput<int16>(), /*test_name=*/Int16, int16, int16, test::DefaultInput<int16>(),
@ -476,19 +470,13 @@ GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES(Pow,
/// Test `tf.RealDiv`. /// Test `tf.RealDiv`.
GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TESTS(RealDiv,
RealDiv, /*test_name=*/Half, Eigen::half, Eigen::half,
/*test_name=*/Half, Eigen::half, Eigen::half, baseline_div);
test::DefaultInput<Eigen::half>(), test::DefaultInputNonZero<Eigen::half>(), GENERATE_DEFAULT_TESTS(RealDiv,
baseline_div); /*test_name=*/Float, float, float, baseline_div);
GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TESTS(RealDiv,
RealDiv, /*test_name=*/Double, double, double, baseline_div);
/*test_name=*/Float, float, float, test::DefaultInput<float>(),
test::DefaultInputNonZero<float>(), baseline_div);
GENERATE_DEFAULT_TESTS_WITH_SPECIFIC_INPUT_VALUES(
RealDiv,
/*test_name=*/Double, double, double, test::DefaultInput<double>(),
test::DefaultInputNonZero<double>(), baseline_div);
/// Test `tf.RightShift`. /// Test `tf.RightShift`.

80
tensorflow/core/kernels/mlir_generated/gpu_unary_ops_test.cc
View File

@ -81,18 +81,11 @@ typename T::value_type baseline_angle(T x) {
return std::arg(x); return std::arg(x);
} }
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Angle, DT_COMPLEX64, DT_FLOAT, baseline_angle,
Angle, DT_COMPLEX64, DT_FLOAT, test::OpsTestConfig().AddTout().NoBufferReuse())
test::ComplexInputFromValues<std::complex<float>>(
test::DefaultInputNonZero<float>(), test::DefaultInputNonZero<float>()),
baseline_angle, test::OpsTestConfig().AddTout().NoBufferReuse())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Angle, DT_COMPLEX128, DT_DOUBLE, baseline_angle,
Angle, DT_COMPLEX128, DT_DOUBLE, test::OpsTestConfig().AddTout().NoBufferReuse())
test::ComplexInputFromValues<std::complex<double>>(
test::DefaultInputNonZero<double>(),
test::DefaultInputNonZero<double>()),
baseline_angle, test::OpsTestConfig().AddTout().NoBufferReuse())
/// Test `tf.Asin`. /// Test `tf.Asin`.
@ -532,33 +525,24 @@ GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES_2(
/// Test `tf.Log`. /// Test `tf.Log`.
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Log, DT_FLOAT, DT_FLOAT, std::log, test::OpsTestConfig())
Log, DT_FLOAT, DT_FLOAT, test::DefaultInputGreaterThanZero<float>(),
std::log, test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Log, DT_DOUBLE, DT_DOUBLE, std::log,
Log, DT_DOUBLE, DT_DOUBLE, test::DefaultInputGreaterThanZero<double>(), test::OpsTestConfig())
std::log, test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES_2( GENERATE_DEFAULT_TEST_2(Log, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT, std::log,
Log, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT, test::OpsTestConfig())
test::DefaultInputGreaterThanZero<Eigen::half>(), std::log,
test::OpsTestConfig())
/// Test `tf.Log1p`. /// Test `tf.Log1p`.
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Log1p, DT_FLOAT, DT_FLOAT, std::log1p,
Log1p, DT_FLOAT, DT_FLOAT, test::DefaultInputGreaterThanZero<float>(), test::OpsTestConfig())
std::log1p, test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Log1p, DT_DOUBLE, DT_DOUBLE, std::log1p,
Log1p, DT_DOUBLE, DT_DOUBLE, test::DefaultInputGreaterThanZero<double>(), test::OpsTestConfig())
std::log1p, test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES_2( GENERATE_DEFAULT_TEST_2(Log1p, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT, std::log1p,
Log1p, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT, test::OpsTestConfig())
test::DefaultInputGreaterThanZero<Eigen::half>(), std::log1p,
test::OpsTestConfig())
/// Test `tf.LogicalNot` /// Test `tf.LogicalNot`
@ -614,24 +598,21 @@ T baseline_rsqrt(T x) {
return 1.0 / std::sqrt(x); return 1.0 / std::sqrt(x);
} }
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Rsqrt, DT_FLOAT, DT_FLOAT, baseline_rsqrt,
Rsqrt, DT_FLOAT, DT_FLOAT, test::DefaultInputGreaterThanZero<float>(), test::OpsTestConfig())
baseline_rsqrt, test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Rsqrt, DT_DOUBLE, DT_DOUBLE, baseline_rsqrt,
Rsqrt, DT_DOUBLE, DT_DOUBLE, test::DefaultInputGreaterThanZero<double>(), test::OpsTestConfig())
baseline_rsqrt, test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES_2( GENERATE_DEFAULT_TEST_2(Rsqrt, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT,
Rsqrt, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT, baseline_rsqrt, test::OpsTestConfig())
test::DefaultInputGreaterThanZero<Eigen::half>(), baseline_rsqrt,
test::OpsTestConfig())
/// Test `tf.Sign`. /// Test `tf.Sign`.
// Reference implementation // Reference implementation
template <typename T> template <typename T>
T baseline_sign(T x) { T baseline_sign(T x) {
if (isnan(x)) return x;
if (x == 0) return 0; if (x == 0) return 0;
if (x < 0) return -1; if (x < 0) return -1;
return 1; return 1;
@ -671,19 +652,14 @@ GENERATE_DEFAULT_TEST(Sinh, DT_DOUBLE, DT_DOUBLE, std::sinh,
/// Test `tf.Sqrt`. /// Test `tf.Sqrt`.
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Sqrt, DT_FLOAT, DT_FLOAT, std::sqrt,
Sqrt, DT_FLOAT, DT_FLOAT, test::DefaultInputGreaterOrEqualToZero<float>(), test::OpsTestConfig())
std::sqrt, test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES( GENERATE_DEFAULT_TEST(Sqrt, DT_DOUBLE, DT_DOUBLE, std::sqrt,
Sqrt, DT_DOUBLE, DT_DOUBLE, test::OpsTestConfig())
test::DefaultInputGreaterOrEqualToZero<double>(), std::sqrt,
test::OpsTestConfig())
GENERATE_DEFAULT_TEST_WITH_SPECIFIC_INPUT_VALUES_2( GENERATE_DEFAULT_TEST_2(Sqrt, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT, std::sqrt,
Sqrt, DT_HALF, DT_FLOAT, DT_HALF, DT_FLOAT, test::OpsTestConfig())
test::DefaultInputGreaterOrEqualToZero<Eigen::half>(), std::sqrt,
test::OpsTestConfig())
/// Test `tf.Tan`. /// Test `tf.Tan`.