experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add TAGS=posix to the CI build.

Browse Source 
Additionally, PR #43571 moved the remove virtual delete macro to public from
private, presumably for the TAGS=posix build. However, that does not seem to be
reproducible and this change moves it back to private.

We are going to keep increasing the CI coverage and if CI passes then we should
be confident that things are ok.

PiperOrigin-RevId: 335685796
Change-Id: I446d9216a8e7c8b8c981d71bd0314dc7709b4e4f
This commit is contained in:
Advait Jain 2020-10-06 11:42:45 -07:00 committed by TensorFlower Gardener
parent 7c769ba200
commit c41b1f7e72
3 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tensorflow/lite/micro/all_ops_resolver.h
View File

@ -26,6 +26,7 @@ class AllOpsResolver : public MicroMutableOpResolver<128> {
public:
AllOpsResolver();
private:
TF_LITE_REMOVE_VIRTUAL_DELETE
};

3
tensorflow/lite/micro/micro_mutable_op_resolver.h
View File

@ -36,7 +36,6 @@ class MicroMutableOpResolver : public MicroOpResolver {
explicit MicroMutableOpResolver(ErrorReporter* error_reporter = nullptr)
: error_reporter_(error_reporter) {}
TF_LITE_REMOVE_VIRTUAL_DELETE
const TfLiteRegistration* FindOp(tflite::BuiltinOperator op) const override {
if (op == BuiltinOperator_CUSTOM) return nullptr;
@ -406,6 +405,8 @@ class MicroMutableOpResolver : public MicroOpResolver {
unsigned int GetRegistrationLength() { return registrations_len_; }
private:
TF_LITE_REMOVE_VIRTUAL_DELETE
TfLiteStatus AddBuiltin(tflite::BuiltinOperator op,
const TfLiteRegistration& registration,
MicroOpResolver::BuiltinParseFunction parser) {

7
tensorflow/lite/micro/tools/ci_build/test_x86.sh
View File

@ -37,6 +37,13 @@ readable_run make -j8 -f tensorflow/lite/micro/tools/make/Makefile BUILD_TYPE=no
readable_run make -f tensorflow/lite/micro/tools/make/Makefile clean
readable_run make -j8 -f tensorflow/lite/micro/tools/make/Makefile BUILD_TYPE=release build
# Next, build with TAGS=posix. See b/170223867 for more details.
# TODO(b/168123200): Since the benchmarks can not currently be run as a test, we
# only build with TAGS=posix. Once benchmarks can be run (and are added to make
# test) we should switch to running all the tests with TAGS=posix.
readable_run make -f tensorflow/lite/micro/tools/make/Makefile clean
readable_run make -s -j8 -f tensorflow/lite/micro/tools/make/Makefile build TAGS=posix
# Next, build w/o release so that we can run the tests and get additional
# debugging info on failures.
readable_run make -f tensorflow/lite/micro/tools/make/Makefile clean