experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Visibility change for including .../core/lib/io:path into modular filesystems.

Browse Source 
We need to include this target as a dependency in modular filesystems instead of
using the more granular `.../core:lib` one to avoid a circular dependency and a
segfault due to ODR violation.

I might revert this once all filesystems are converted to the modular world and
we no longer need them to reside in the experimental directory.

Part of work for modular filesystem plugins. For more details, consult the RFC at
https://github.com/tensorflow/community/blob/master/rfcs/20190506-filesystem-plugin-modular-tensorflow.md

PiperOrigin-RevId: 278403469
Change-Id: I7b3d996ac3d3553342d4796a67d41192a3d3e1da
This commit is contained in:
Mihai Maruseac 2019-11-04 09:57:42 -08:00 committed by TensorFlower Gardener
parent acc15ae822
commit bf282dece5
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tensorflow/core/lib/io/BUILD
View File

@ -1,5 +1,7 @@
package(
default_visibility = [
"//tensorflow/c/experimental/filesystem:__pkg__",
"//tensorflow/c/experimental/filesystem/plugins/posix:__pkg__",
# tensorflow/core:lib effectively exposes all targets under tensorflow/core/lib/**
"//tensorflow/core:__pkg__",
# tensorflow/core/platform:env uses :path
@ -8,7 +10,7 @@ package(
licenses = ["notice"], # Apache 2.0
)
# Todo(bmzhao): Remaining targets to add to this BUILD file are:
# TODO(bmzhao): Remaining targets to add to this BUILD file are:
# block, block_builder, buffered_inputstream, format, inputbuffer,
# random_inputstream, record_reader, record_writer, snappy/snappy_inputbuffer
# snappy/snappy_outputbuffer, table, table_builder, two_level_iterator,