Populate more error messages to the users.

PiperOrigin-RevId: 299445320
Change-Id: Ia0d02c25ac3254444f7293d60c912989ad77ee3c
This commit is contained in:
A. Unique TensorFlower 2020-03-06 15:06:27 -08:00 committed by TensorFlower Gardener
parent 317189e108
commit beabfbcfa6
2 changed files with 7 additions and 8 deletions

View File

@ -97,8 +97,8 @@ Status Profile(const string& service_addr, const string& logdir,
FromGrpcStatus(stub->Profile(&context, request, &response))); FromGrpcStatus(stub->Profile(&context, request, &response)));
if (!response.empty_trace()) { if (!response.empty_trace()) {
TF_CHECK_OK(SaveTensorboardProfile(logdir, session_id, request.host_name(), TF_RETURN_IF_ERROR(SaveTensorboardProfile(
response, &std::cout)); logdir, session_id, request.host_name(), response, &std::cout));
// Print this at the end so that it's not buried in irrelevant LOG messages. // Print this at the end so that it's not buried in irrelevant LOG messages.
std::cout std::cout
<< "NOTE: using the trace duration " << duration_ms << "ms.\n" << "NOTE: using the trace duration " << duration_ms << "ms.\n"

View File

@ -70,16 +70,15 @@ class ProfilerSessionWrapper {
tensorflow::Status status; tensorflow::Status status;
status = session_->CollectData(&xspace); status = session_->CollectData(&xspace);
session_.reset(); session_.reset();
if (!status.ok()) { tensorflow::MaybeRaiseRegisteredFromStatus(status);
tensorflow::MaybeRaiseRegisteredFromStatus(status);
return;
}
tensorflow::ProfileResponse response; tensorflow::ProfileResponse response;
tensorflow::ProfileRequest request = MakeProfileRequest( tensorflow::ProfileRequest request = MakeProfileRequest(
logdir_, tensorflow::profiler::GetCurrentTimeStampAsString(), logdir_, tensorflow::profiler::GetCurrentTimeStampAsString(),
tensorflow::port::Hostname()); tensorflow::port::Hostname());
tensorflow::profiler::ConvertXSpaceToProfileResponse(xspace, request, status = tensorflow::profiler::ConvertXSpaceToProfileResponse(
&response); xspace, request, &response);
tensorflow::MaybeRaiseRegisteredFromStatus(status);
std::stringstream ss; // Record LOG messages. std::stringstream ss; // Record LOG messages.
status = tensorflow::profiler::SaveTensorboardProfile( status = tensorflow::profiler::SaveTensorboardProfile(