experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Disable horizontal fusion by default

Browse Source 
We have an internal customer who has asked us to do a critical systems freeze
until Feb 7.  We will re-enable the pass on Feb 7.

PiperOrigin-RevId: 293206387
Change-Id: I6b401fd68b2219c27136937f860dd21690d3e273
This commit is contained in:
Sanjoy Das 2020-02-04 12:43:13 -08:00 committed by TensorFlower Gardener
parent f6768dc78d
commit bd23bbf19c
4 changed files with 30 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tensorflow/compiler/xla/debug_options_flags.cc
View File

@ -535,6 +535,12 @@ static void AllocateFlags() {
bool_setter_for(&DebugOptions::set_xla_gpu_deterministic_reductions),
flag_values->xla_gpu_deterministic_reductions(),
"Always run deterministic reductions on GPU"),
// TODO(b/148871440): Enable by default on Feb 7.
tensorflow::Flag(
"xla_gpu_use_horizontal_fusion",
bool_setter_for(&DebugOptions::set_xla_gpu_use_horizontal_fusion),
flag_values->xla_gpu_use_horizontal_fusion(),
"Allow horizontal fusion for XLA GPU."),
});
ParseFlagsFromEnvAndDieIfUnknown("XLA_FLAGS", *flag_objects);
}

14
tensorflow/compiler/xla/service/gpu/gpu_compiler.cc
View File

@ -280,12 +280,14 @@ Status GpuCompiler::OptimizeHloModule(
fusion.AddPass<HloDCE>();
TF_RETURN_IF_ERROR(fusion.Run(hlo_module).status());
HloPassPipeline horizontal_fusion("horizontal_fusion");
horizontal_fusion.AddPass<GpuHorizontalFusion>();
horizontal_fusion.AddPass<HloCSE>(/*is_layout_sensitive=*/true,
/*only_fusion_computations=*/true);
horizontal_fusion.AddPass<HloDCE>();
TF_RETURN_IF_ERROR(horizontal_fusion.Run(hlo_module).status());
if (hlo_module->config().debug_options().xla_gpu_use_horizontal_fusion()) {
HloPassPipeline horizontal_fusion("horizontal_fusion");
horizontal_fusion.AddPass<GpuHorizontalFusion>();
horizontal_fusion.AddPass<HloCSE>(/*is_layout_sensitive=*/true,
/*only_fusion_computations=*/true);
horizontal_fusion.AddPass<HloDCE>();
TF_RETURN_IF_ERROR(horizontal_fusion.Run(hlo_module).status());
}
}
return Status::OK();

12
tensorflow/compiler/xla/service/gpu/horizontal_fusion_test.cc
View File

@ -37,7 +37,17 @@ namespace {
namespace op = xla::testing::opcode_matchers;
class HorizontalFusionTest : public HloTestBase {};
class HorizontalFusionTest : public HloTestBase {
protected:
HloModuleConfig GetModuleConfigWithHorizontalFusionEnabled() {
DebugOptions debug_options = GetDebugOptionsForTest();
debug_options.set_xla_gpu_use_horizontal_fusion(true);
HloModuleConfig config;
config.set_debug_options(debug_options);
return config;
}
};
TEST_F(HorizontalFusionTest, BasicTest) {
auto module = ParseAndReturnVerifiedModule(R"(

6
tensorflow/compiler/xla/xla.proto
View File

@ -260,7 +260,11 @@ message DebugOptions {
// Guarantee run-to-run determinism from reductions on XLA:GPU.
bool xla_gpu_deterministic_reductions = 130;
// Next id: 133
// Enable horizontal fusion on XLA GPU.
bool xla_gpu_use_horizontal_fusion = 133;
// Next id: 134
// Extra options to pass to the compilation backend (e.g. LLVM); specific
// interpretation of these values is left to the backend.