experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[XLA] Print more digits when hitting miscomparisons

Browse Source 
We should print enough digits to make the output unambiguous.

PiperOrigin-RevId: 278990208
Change-Id: I198a9f0d4c16015b1d7b6c5bb81a9e1400d3678f
This commit is contained in:
David Majnemer 2019-11-06 19:16:32 -08:00 committed by TensorFlower Gardener
parent 089a0c06f8
commit bcc6b7a33d
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
tensorflow/compiler/xla/literal_comparison.cc
View File

@ -238,19 +238,30 @@ float IsNan(half value) {
}
// Converts the given floating-point value to a string.
template <typename NativeT>
string FpValueToString(NativeT value) {
return absl::StrFormat("%8.4g", static_cast<double>(value));
string FpValueToString(bfloat16 value) {
return absl::StrFormat("%10.4g", static_cast<double>(value));
}
template <>
string FpValueToString<complex64>(complex64 value) {
return absl::StrFormat("%8.4g + %8.4fi", value.real(), value.imag());
string FpValueToString(half value) {
return absl::StrFormat("%11.5g", static_cast<double>(value));
}
template <>
string FpValueToString<complex128>(complex128 value) {
return absl::StrFormat("%8.4g + %8.4fi", value.real(), value.imag());
string FpValueToString(float value) {
return absl::StrFormat("%15.9g", static_cast<double>(value));
}
string FpValueToString(double value) {
return absl::StrFormat("%24.17g", value);
}
string FpValueToString(complex64 value) {
return absl::StrCat(FpValueToString(value.real()), " + ",
FpValueToString(value.imag()));
}
string FpValueToString(complex128 value) {
return absl::StrCat(FpValueToString(value.real()), " + ",
FpValueToString(value.imag()));
}
// A wrapper of std::abs to include data types that are not supported by