From b90cdb966b700f583f2c48468cf51bb5d94326a5 Mon Sep 17 00:00:00 2001
From: Deven Desai <deven.desai.amd@gmail.com>
Date: Wed, 25 Nov 2020 02:02:40 +0000
Subject: [PATCH] Adding no_rocm tag from unit-tests that are now failing on
the ROCm platform
---
tensorflow/compiler/xla/service/gpu/tests/BUILD | 4 ++--
tensorflow/compiler/xla/tests/BUILD | 12 +++++++++---
tensorflow/python/BUILD | 3 +++
tensorflow/python/keras/engine/BUILD | 1 +
tensorflow/python/kernel_tests/BUILD | 1 +
tensorflow/python/kernel_tests/distributions/BUILD | 1 +
tensorflow/python/kernel_tests/linalg/sparse/BUILD | 5 ++++-
tensorflow/python/kernel_tests/signal/BUILD | 1 +
8 files changed, 22 insertions(+), 6 deletions(-)
diff --git a/tensorflow/compiler/xla/service/gpu/tests/BUILD b/tensorflow/compiler/xla/service/gpu/tests/BUILD
index 1615d27ec11..4e941769391 100644
--- a/tensorflow/compiler/xla/service/gpu/tests/BUILD
+++ b/tensorflow/compiler/xla/service/gpu/tests/BUILD
@@ -410,7 +410,7 @@ tf_cc_test(
tf_cc_test(
name = "gpu_unrolling_test",
srcs = ["gpu_unrolling_test.cc"],
- tags = tf_cuda_tests_tags(),
+ tags = tf_cuda_tests_tags() + ["no_rocm"],
deps = [
":gpu_codegen_test",
"//tensorflow/compiler/xla/service:hlo_module_config",
@@ -441,7 +441,7 @@ tf_cc_test(
tf_cc_test(
name = "gpu_atomic_test",
srcs = ["gpu_atomic_test.cc"],
- tags = tf_cuda_tests_tags(),
+ tags = tf_cuda_tests_tags() + ["no_rocm"],
deps = [
":gpu_codegen_test",
"//tensorflow/compiler/xla/tests:filecheck",
diff --git a/tensorflow/compiler/xla/tests/BUILD b/tensorflow/compiler/xla/tests/BUILD
index 18324c05797..9db6ed8f47a 100644
--- a/tensorflow/compiler/xla/tests/BUILD
+++ b/tensorflow/compiler/xla/tests/BUILD
@@ -367,6 +367,7 @@ xla_test(
"conv_depthwise_test.cc",
],
shard_count = 50,
+ tags = ["no_rocm"], # ROCm 3.9 regression
deps = [
":conv_depthwise_common",
":test_macros_header",
@@ -388,6 +389,7 @@ xla_test(
timeout = "long",
srcs = ["conv_depthwise_backprop_filter_test.cc"],
shard_count = 40,
+ tags = ["no_rocm"], # ROCm 3.9 regression
deps = [
":test_macros_header",
"//tensorflow/compiler/xla:execution_options_util",
@@ -412,6 +414,7 @@ xla_test(
"cpu",
],
shard_count = 50,
+ tags = ["no_rocm"], # ROCm 3.9 regression
deps = [
":client_library_test_base",
":hlo_test_base",
@@ -921,7 +924,7 @@ xla_test(
srcs = ["dot_operation_test.cc"],
shard_count = 20,
tags = [
- "no_rocm",
+ "no_rocm", # ROCm 3.9 regression
"optonly",
],
deps = [
@@ -955,7 +958,7 @@ xla_test(
backends = ["gpu"],
shard_count = 20,
tags = [
- "no_rocm",
+ "no_rocm", # ROCm 3.9 regression
"optonly",
# TODO(b/151340488): Timed out on 2020-03-12.
"nozapfhahn",
@@ -1022,7 +1025,7 @@ xla_test(
},
shard_count = 20,
tags = [
- "no_rocm",
+ "no_rocm", # ROCm 3.9 regression
"optonly",
],
deps = [
@@ -1250,6 +1253,7 @@ xla_test(
"cpu": ["nomsan"],
},
shard_count = 30,
+ tags = ["no_rocm"], # ROCm 3.9 regression
deps = [
":test_macros_header",
"//tensorflow/compiler/xla:array3d",
@@ -1274,6 +1278,7 @@ xla_test(
timeout = "long",
srcs = ["convolution_dimension_numbers_test.cc"],
shard_count = 20,
+ tags = ["no_rocm"], # ROCm 3.9 regression
deps = [
":test_macros_header",
"//tensorflow/compiler/xla:array4d",
@@ -2316,6 +2321,7 @@ xla_test(
name = "multioutput_fusion_test",
srcs = ["multioutput_fusion_test.cc"],
backends = ["gpu"],
+ tags = ["no_rocm"], # ROCm 3.9 regression
deps = [
":test_macros_header",
"//tensorflow/compiler/xla:literal",
diff --git a/tensorflow/python/BUILD b/tensorflow/python/BUILD
index f1f835e62c1..9c933beccdb 100644
--- a/tensorflow/python/BUILD
+++ b/tensorflow/python/BUILD
@@ -2605,6 +2605,7 @@ cuda_py_test(
python_version = "PY3",
shard_count = 10,
tags = [
+ "no_rocm",
"noasan",
"optonly",
],
@@ -2650,6 +2651,7 @@ tf_py_test(
srcs = ["framework/importer_test.py"],
main = "framework/importer_test.py",
python_version = "PY3",
+ tags = ["no_rocm"],
deps = [
":array_ops",
":client_testlib",
@@ -5470,6 +5472,7 @@ cuda_py_test(
srcs = ["ops/nn_fused_batchnorm_test.py"],
python_version = "PY3",
shard_count = 24,
+ tags = ["no_rocm"],
deps = [
":array_ops",
":client_testlib",
diff --git a/tensorflow/python/keras/engine/BUILD b/tensorflow/python/keras/engine/BUILD
index 99e736df645..ed9f42c5748 100644
--- a/tensorflow/python/keras/engine/BUILD
+++ b/tensorflow/python/keras/engine/BUILD
@@ -602,6 +602,7 @@ tf_py_test(
shard_count = 8,
tags = [
"no-internal-py3",
+ "no_rocm",
"nomac", # TODO(mihaimaruseac): b/127695564
],
deps = [
diff --git a/tensorflow/python/kernel_tests/BUILD b/tensorflow/python/kernel_tests/BUILD
index bc65c78819e..be54ca2a48a 100644
--- a/tensorflow/python/kernel_tests/BUILD
+++ b/tensorflow/python/kernel_tests/BUILD
@@ -1719,6 +1719,7 @@ cuda_py_test(
name = "betainc_op_test",
size = "small",
srcs = ["betainc_op_test.py"],
+ tags = ["no_rocm"], # ROCm 3.9 regression
xla_tags = [
"no_cuda_asan", # times out
],
diff --git a/tensorflow/python/kernel_tests/distributions/BUILD b/tensorflow/python/kernel_tests/distributions/BUILD
index d4f29d4837f..7bdcdef4858 100644
--- a/tensorflow/python/kernel_tests/distributions/BUILD
+++ b/tensorflow/python/kernel_tests/distributions/BUILD
@@ -61,6 +61,7 @@ cuda_py_test(
size = "small",
srcs = ["beta_test.py"],
tags = [
+ "no_rocm", # ROCm 3.9 regression
"notsan", # b/173653918
],
xla_tags = [
diff --git a/tensorflow/python/kernel_tests/linalg/sparse/BUILD b/tensorflow/python/kernel_tests/linalg/sparse/BUILD
index 96ebc38ce5a..0352ae764b4 100644
--- a/tensorflow/python/kernel_tests/linalg/sparse/BUILD
+++ b/tensorflow/python/kernel_tests/linalg/sparse/BUILD
@@ -40,7 +40,10 @@ cuda_py_test(
srcs = ["csr_sparse_matrix_ops_test.py"],
main = "csr_sparse_matrix_ops_test.py",
shard_count = 10,
- tags = ["notsan"], # b/149115441
+ tags = [
+ "no_rocm", # ROCm 3.8 regression
+ "notsan", # b/149115441
+ ],
deps = [
"//tensorflow/python/ops/linalg/sparse",
"//tensorflow/python/ops/linalg/sparse:gen_sparse_csr_matrix_ops",
diff --git a/tensorflow/python/kernel_tests/signal/BUILD b/tensorflow/python/kernel_tests/signal/BUILD
index bd893184570..d2d6296aef4 100644
--- a/tensorflow/python/kernel_tests/signal/BUILD
+++ b/tensorflow/python/kernel_tests/signal/BUILD
@@ -125,6 +125,7 @@ cuda_py_tests(
srcs = ["spectral_ops_test.py"],
python_version = "PY3",
tags = [
+ "no_rocm",
"nomac",
],
deps = [