diff --git a/tensorflow/compiler/xla/service/BUILD b/tensorflow/compiler/xla/service/BUILD index f21ce6bc3ac..30182d4b16f 100644 --- a/tensorflow/compiler/xla/service/BUILD +++ b/tensorflow/compiler/xla/service/BUILD @@ -1683,10 +1683,8 @@ cc_library( deps = [ ":buffer_assignment", ":hlo", - ":hlo_ordering", ":hlo_proto", "//tensorflow/compiler/xla:status", - "//tensorflow/compiler/xla:util", "//tensorflow/core:lib", ], ) diff --git a/tensorflow/compiler/xla/service/hlo_computation.cc b/tensorflow/compiler/xla/service/hlo_computation.cc index 77279cdbc5c..24504b5ade7 100644 --- a/tensorflow/compiler/xla/service/hlo_computation.cc +++ b/tensorflow/compiler/xla/service/hlo_computation.cc @@ -311,7 +311,6 @@ void ComputeComputationPostOrder( visited->insert(computation); post_order->push_back(computation); - return; } } // namespace diff --git a/tensorflow/core/common_runtime/stats_publisher_interface.cc b/tensorflow/core/common_runtime/stats_publisher_interface.cc index 408c901d170..f589140cd6f 100644 --- a/tensorflow/core/common_runtime/stats_publisher_interface.cc +++ b/tensorflow/core/common_runtime/stats_publisher_interface.cc @@ -15,29 +15,30 @@ limitations under the License. #include "tensorflow/core/common_runtime/stats_publisher_interface.h" -namespace tensorflow { +#include "tensorflow/core/framework/graph.pb.h" +namespace tensorflow { namespace { + // NoOpStatsPublisher provides an dummy/no-op implementation of // StatsPublisherInterface. class NoOpStatsPublisher : public StatsPublisherInterface { public: - NoOpStatsPublisher(){}; + NoOpStatsPublisher() = default; - void PublishStatsProto(const StepStats& step_stats) override { return; } + void PublishStatsProto(const StepStats& step_stats) override {} void PublishGraphProto( - const std::vector<const GraphDef*>& graph_defs) override { - return; - } + const std::vector<const GraphDef*>& graph_defs) override {} std::unique_ptr<ProfileHandler> GetProfileHandler( uint64 step, int64 execution_count, const RunOptions& ropts) override { return nullptr; } - ~NoOpStatsPublisher() override {} + ~NoOpStatsPublisher() override = default; }; + } // namespace std::unique_ptr<StatsPublisherInterface> CreateNoOpStatsPublisher( diff --git a/tensorflow/core/framework/rendezvous.cc b/tensorflow/core/framework/rendezvous.cc index 7dc4a509257..6e578cdbab4 100644 --- a/tensorflow/core/framework/rendezvous.cc +++ b/tensorflow/core/framework/rendezvous.cc @@ -283,7 +283,6 @@ class LocalRendezvousImpl : public Rendezvous { } CHECK(table_.insert({key_hash, item}).second); mu_.unlock(); - return; } void StartAbort(const Status& status) override { diff --git a/tensorflow/core/framework/tensor_test.cc b/tensorflow/core/framework/tensor_test.cc index fdab7daf76a..369f64e9e2d 100644 --- a/tensorflow/core/framework/tensor_test.cc +++ b/tensorflow/core/framework/tensor_test.cc @@ -820,16 +820,14 @@ namespace { // failures to allocate. class DummyCPUAllocator : public Allocator { public: - DummyCPUAllocator() {} + DummyCPUAllocator() = default; string Name() override { return "cpu"; } void* AllocateRaw(size_t alignment, size_t num_bytes) override { return nullptr; } - void DeallocateRaw(void* ptr) override { return; } + void DeallocateRaw(void* ptr) override {} }; -} // namespace - TEST(Tensor, FailureToAllocate) { TensorShape shape({1}); DummyCPUAllocator allocator; @@ -1080,4 +1078,5 @@ static void BM_CreateAndMoveCtrWithBuf(int iters) { } BENCHMARK(BM_CreateAndMoveCtrWithBuf); +} // namespace } // namespace tensorflow diff --git a/tensorflow/examples/wav_to_spectrogram/BUILD b/tensorflow/examples/wav_to_spectrogram/BUILD index 1e72324fb05..5923fa59293 100644 --- a/tensorflow/examples/wav_to_spectrogram/BUILD +++ b/tensorflow/examples/wav_to_spectrogram/BUILD @@ -15,12 +15,8 @@ exports_files(["LICENSE"]) cc_library( name = "wav_to_spectrogram_lib", - srcs = [ - "wav_to_spectrogram.cc", - ], - hdrs = [ - "wav_to_spectrogram.h", - ], + srcs = ["wav_to_spectrogram.cc"], + hdrs = ["wav_to_spectrogram.h"], deps = [ "//tensorflow/cc:cc_ops", "//tensorflow/core:framework_internal", @@ -30,13 +26,10 @@ cc_library( cc_binary( name = "wav_to_spectrogram", - srcs = [ - "main.cc", - ], + srcs = ["main.cc"], deps = [ ":wav_to_spectrogram_lib", "//tensorflow/core:framework_internal", - "//tensorflow/core:tensorflow", ], )