From ab2f4b7183562302cb0f9384a6674457bd4bd6c0 Mon Sep 17 00:00:00 2001
From: "ag.ramesh" <ag.ramesh@intel.com>
Date: Thu, 5 Nov 2020 07:24:15 -0800
Subject: [PATCH] Prevent unnecessary copies of oneDNN in .so files.
---
tensorflow/core/BUILD | 3 +--
tensorflow/core/grappler/optimizers/BUILD | 6 +-----
tensorflow/core/util/BUILD | 6 +-----
tensorflow/tensorflow.bzl | 5 ++---
4 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/tensorflow/core/BUILD b/tensorflow/core/BUILD
index 8613d979d6d..5f307a62f62 100644
--- a/tensorflow/core/BUILD
+++ b/tensorflow/core/BUILD
@@ -129,7 +129,6 @@ load("@local_config_tensorrt//:build_defs.bzl", "if_tensorrt")
load(
"//third_party/mkl:build_defs.bzl",
"if_mkl",
- "mkl_deps",
)
package(
@@ -1722,7 +1721,7 @@ tf_cuda_library(
] + if_static(
extra_deps = ["@com_google_protobuf//:protobuf"],
otherwise = ["@com_google_protobuf//:protobuf_headers"],
- ) + mkl_deps(),
+ ),
alwayslink = 1,
)
diff --git a/tensorflow/core/grappler/optimizers/BUILD b/tensorflow/core/grappler/optimizers/BUILD
index a1af69354e4..03e49016d7c 100644
--- a/tensorflow/core/grappler/optimizers/BUILD
+++ b/tensorflow/core/grappler/optimizers/BUILD
@@ -12,10 +12,6 @@ load(
"//tensorflow/core/platform:build_config_root.bzl",
"if_static",
)
-load(
- "//third_party/mkl:build_defs.bzl",
- "mkl_deps",
-)
package(
licenses = ["notice"], # Apache 2.0
@@ -638,7 +634,7 @@ cc_library(
"//tensorflow/core/grappler/costs:virtual_placer",
"@com_google_absl//absl/container:flat_hash_map",
"@com_google_absl//absl/container:flat_hash_set",
- ] + mkl_deps(),
+ ],
)
tf_cuda_cc_test(
diff --git a/tensorflow/core/util/BUILD b/tensorflow/core/util/BUILD
index 0630cb56ba0..4ce9c0ce88e 100644
--- a/tensorflow/core/util/BUILD
+++ b/tensorflow/core/util/BUILD
@@ -25,10 +25,6 @@ load("//tensorflow:tensorflow.bzl", "get_compatible_with_portable")
# buildifier: disable=same-origin-load
load("//tensorflow:tensorflow.bzl", "tf_version_info_genrule")
-load(
- "//third_party/mkl:build_defs.bzl",
- "mkl_deps",
-)
load(
"//tensorflow/core/platform:build_config_root.bzl",
"if_static",
@@ -707,7 +703,7 @@ tf_cuda_only_cc_test(
"//tensorflow/core:test",
"//tensorflow/core:test_main",
"//third_party/eigen3",
- ] + mkl_deps(),
+ ],
)
tf_cc_tests(
diff --git a/tensorflow/tensorflow.bzl b/tensorflow/tensorflow.bzl
index 3bdcdfebbcd..6c65964dec5 100644
--- a/tensorflow/tensorflow.bzl
+++ b/tensorflow/tensorflow.bzl
@@ -39,7 +39,6 @@ load(
"if_enable_mkl",
"if_mkl",
"if_mkl_ml",
- "mkl_deps",
)
load(
"//third_party/mkl_dnn:build_defs.bzl",
@@ -1270,7 +1269,7 @@ def tf_cc_test_mkl(
"-lm",
],
}) + _rpath_linkopts(src_to_test_name(src)),
- deps = deps + tf_binary_dynamic_kernel_deps(kernels) + mkl_deps(),
+ deps = deps + tf_binary_dynamic_kernel_deps(kernels) + if_mkl_ml(["//third_party/mkl:intel_binary_blob"]),
data = data + tf_binary_dynamic_kernel_dsos(),
exec_properties = tf_exec_properties({"tags": tags}),
linkstatic = linkstatic,
@@ -2677,7 +2676,7 @@ def tf_python_pybind_extension(
features = features,
copts = copts,
hdrs = hdrs,
- deps = deps + tf_binary_pybind_deps() + mkl_deps(),
+ deps = deps + tf_binary_pybind_deps() + if_mkl_ml(["//third_party/mkl:intel_binary_blob"]),
defines = defines,
visibility = visibility,
link_in_framework = True,