From a807755db184c2d2c3b9bcca65457e9915508650 Mon Sep 17 00:00:00 2001
From: Skye Wanderman-Milne <skyewm@google.com>
Date: Mon, 29 Jan 2018 14:40:07 -0800
Subject: [PATCH] Use Popen.communicate() instead of read() in
stacktrace_handler_test.py.
This avoids potential deadlock, see the warnings in
https://docs.python.org/2/library/subprocess.html#popen-objects. I
found that enabling the C API caused us to deadlock without this
change.
PiperOrigin-RevId: 183730170
---
tensorflow/python/platform/stacktrace_handler_test.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tensorflow/python/platform/stacktrace_handler_test.py b/tensorflow/python/platform/stacktrace_handler_test.py
index 3f0e534f4cb..f2071f9d54c 100644
--- a/tensorflow/python/platform/stacktrace_handler_test.py
+++ b/tensorflow/python/platform/stacktrace_handler_test.py
@@ -57,7 +57,8 @@ class StacktraceHandlerTest(test.TestCase):
# Capture its output. capture both stdout and stderr and append them.
# We are not worried about timing or order of messages in this test.
- child_output = child_process.stdout.read() + child_process.stderr.read()
+ child_stdout, child_stderr = child_process.communicate()
+ child_output = child_stdout + child_stderr
# Make sure the child process is dead before we proceed.
child_process.wait()