experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

For Substr check pos and len rank equality only when their rank is known.

Browse Source 
This fixes a bug where len has unknown rank, while pos has known shape. The WithRank(...) check returned error in such a case. Here we compare their ranks only when both pos and len have known rank.

PiperOrigin-RevId: 275370109
Change-Id: I8df36f3d4dcf3104e246e8605689b9ded3d9c783
This commit is contained in:
Prakalp Srivastava 2019-10-17 17:06:29 -07:00 committed by TensorFlower Gardener
parent cc951f765c
commit a680ed0bf0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tensorflow/core/ops/string_ops.cc
View File

@ -261,8 +261,10 @@ REGISTER_OP("Substr")
ShapeHandle pos_shape = c->input(1);
ShapeHandle len_shape = c->input(2);
ShapeHandle unused;
// Check that pos/len have same rank
TF_RETURN_IF_ERROR(c->WithRank(pos_shape, c->Rank(len_shape), &unused));
// If len rank is known, check that pos and len have the same rank
if (c->RankKnown(len_shape)) {
TF_RETURN_IF_ERROR(c->WithRank(pos_shape, c->Rank(len_shape), &unused));
}
// Check that dimensions are equal
for (int32 i = 0; i < c->Rank(pos_shape); ++i) {
DimensionHandle pos_dim = c->Dim(pos_shape, i);