experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Print LLVM diagnostics only at VLOG(1)

Browse Source 
These are not actionable by our end users, and it usually just confuses them.

PiperOrigin-RevId: 353372479
Change-Id: I0994bfd35f0a5145349f54e26b35b11bcb85f0ed
This commit is contained in:
Sanjoy Das 2021-01-22 21:42:36 -08:00 committed by TensorFlower Gardener
parent 98e48ecca3
commit a34316afa2
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tensorflow/compiler/xla/service/gpu/gpu_compiler.cc
View File

@ -660,6 +660,16 @@ static Status CompileModuleToLlvmIrImpl(
return Status::OK(); return Status::OK();
} }
static void NullDiagnosticHandler(const llvm::DiagnosticInfo& diag_info,
void* context) {
std::string error_string;
llvm::raw_string_ostream string_printer(error_string);
llvm::DiagnosticPrinterRawOStream diagnostic_printer(string_printer);
diag_info.print(diagnostic_printer);
VLOG(1) << error_string;
}
StatusOr<std::pair<std::string, std::vector<uint8>>> StatusOr<std::pair<std::string, std::vector<uint8>>>
GpuCompiler::CompileToTargetBinary(const HloModuleConfig& module_config, GpuCompiler::CompileToTargetBinary(const HloModuleConfig& module_config,
std::unique_ptr<llvm::Module> llvm_module, std::unique_ptr<llvm::Module> llvm_module,
@ -676,6 +686,9 @@ GpuCompiler::CompileToTargetBinary(const HloModuleConfig& module_config,
XLA_SCOPED_LOGGING_TIMER( XLA_SCOPED_LOGGING_TIMER(
"GpuCompiler::RunBackend - Running LLVM verifier"); "GpuCompiler::RunBackend - Running LLVM verifier");
llvm_module->getContext().setDiagnosticHandlerCallBack(
NullDiagnosticHandler, nullptr);
std::string err; std::string err;
llvm::raw_string_ostream err_stream(err); llvm::raw_string_ostream err_stream(err);
@ -797,13 +810,6 @@ GpuCompiler::CompileToTargetBinary(const HloModuleConfig& module_config,
llvm::LLVMContext context; llvm::LLVMContext context;
std::string buffer; std::string buffer;
llvm::raw_string_ostream error(buffer); llvm::raw_string_ostream error(buffer);
llvm::DiagnosticPrinterRawOStream printer(error);
auto DiagnosticHandler = [](const llvm::DiagnosticInfo& diag_info,
void* Context) {
auto printer = static_cast<llvm::DiagnosticPrinterRawOStream*>(Context);
diag_info.print(*printer);
};
context.setDiagnosticHandlerCallBack(DiagnosticHandler, &printer);
std::unique_ptr<llvm::Module> new_llvm_module; std::unique_ptr<llvm::Module> new_llvm_module;
// Switch to a new context by dumping and re-parsing LLVM IR. Each thread // Switch to a new context by dumping and re-parsing LLVM IR. Each thread