From 9119dcbef3389480aeeb260587a320803149ffec Mon Sep 17 00:00:00 2001 From: Anna R Date: Thu, 22 Oct 2020 16:05:33 -0700 Subject: [PATCH] Disabling tests that are failing with cuda asan. PiperOrigin-RevId: 338567923 Change-Id: I4941a6ac06c81a02d3c309148e96b37f746b9245 --- tensorflow/compiler/jit/BUILD | 9 ++++++--- tensorflow/compiler/tests/BUILD | 1 + tensorflow/compiler/xrt/tests/BUILD | 4 +++- tensorflow/core/kernels/BUILD | 7 ++++++- tensorflow/core/kernels/image/BUILD | 10 ++++++++-- tensorflow/core/kernels/mlir_generated/BUILD | 8 ++++++-- tensorflow/core/util/BUILD | 3 +++ tensorflow/python/BUILD | 3 +++ tensorflow/python/kernel_tests/BUILD | 6 ++++++ tensorflow/stream_executor/cuda/BUILD | 12 +++++++++--- 10 files changed, 51 insertions(+), 12 deletions(-) diff --git a/tensorflow/compiler/jit/BUILD b/tensorflow/compiler/jit/BUILD index deb3396d89c..7bd7b5964f9 100644 --- a/tensorflow/compiler/jit/BUILD +++ b/tensorflow/compiler/jit/BUILD @@ -868,9 +868,12 @@ tf_cc_test( "partially_decluster_pass_test.cc", "rearrange_function_argument_pass_test.cc", ], - # TODO(b/141643254) Re-enable msan after fixing use-of-uninitialized-value - # error. - tags = ["nomsan"] + tf_cuda_tests_tags(), + tags = [ + # TODO(b/141643254) Re-enable msan after fixing + # use-of-uninitialized-value error. + "nomsan", + "no_cuda_asan", # TODO(b/171317460): re-enable. + ] + tf_cuda_tests_tags(), deps = [ ":common", ":compilability_check_util", diff --git a/tensorflow/compiler/tests/BUILD b/tensorflow/compiler/tests/BUILD index 3f058fe0773..ecffd276f10 100644 --- a/tensorflow/compiler/tests/BUILD +++ b/tensorflow/compiler/tests/BUILD @@ -1698,6 +1698,7 @@ tf_cuda_cc_test( name = "unary_ops_composition_test", srcs = ["unary_ops_composition_test.cc"], tags = [ + "no_cuda_asan", # TODO(b/171317888): re-enable. "no_pip", # TODO(b/149738646): fix pip install so these tests run on kokoro pip ] + tf_cuda_tests_tags(), deps = [ diff --git a/tensorflow/compiler/xrt/tests/BUILD b/tensorflow/compiler/xrt/tests/BUILD index 724cfe38d54..4f3f4b36970 100644 --- a/tensorflow/compiler/xrt/tests/BUILD +++ b/tensorflow/compiler/xrt/tests/BUILD @@ -73,7 +73,9 @@ tf_cuda_cc_test( "--xla_test_device=XLA_GPU", "--xla_platform=GPU", ], - tags = tf_cuda_tests_tags(), + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171319142): re-enable. + ], deps = [ ":raw_api_test_lib", "//tensorflow/compiler/jit:xla_gpu_device", diff --git a/tensorflow/core/kernels/BUILD b/tensorflow/core/kernels/BUILD index c576ff132e8..edf2567a4d9 100644 --- a/tensorflow/core/kernels/BUILD +++ b/tensorflow/core/kernels/BUILD @@ -1657,6 +1657,9 @@ tf_cuda_cc_test( name = "conv_ops_test", size = "medium", srcs = ["conv_ops_test.cc"], + tags = [ + "no_cuda_asan", # TODO(b/171342275): re-enable. + ], deps = [ ":conv_ops", ":ops_testutil", @@ -1756,7 +1759,9 @@ tf_cuda_cc_test( name = "depthwise_conv_ops_test", size = "small", srcs = ["depthwise_conv_ops_test.cc"], - tags = tf_cuda_tests_tags(), + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171342266): re-enable. + ], deps = [ ":conv_ops", ":ops_testutil", diff --git a/tensorflow/core/kernels/image/BUILD b/tensorflow/core/kernels/image/BUILD index 31a50576808..a94e98dc593 100644 --- a/tensorflow/core/kernels/image/BUILD +++ b/tensorflow/core/kernels/image/BUILD @@ -353,7 +353,10 @@ tf_cuda_cc_test( "resize_bilinear_op_test.cc", "resize_nearest_neighbor_op_test.cc", ], - tags = ["no_cuda_on_cpu_tap"], + tags = [ + "no_cuda_asan", # TODO(b/171334997): re-enable + "no_cuda_on_cpu_tap", + ], deps = [ ":image", ":sampling_kernels", @@ -387,7 +390,10 @@ tf_cuda_cc_test( tf_cuda_cc_test( name = "non_max_suppression_op_gpu_test", srcs = ["non_max_suppression_op_gpu_test.cc"], - tags = tf_cuda_tests_tags() + ["no_cuda_on_cpu_tap"], + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171263349): re-enable. + "no_cuda_on_cpu_tap", + ], deps = [ ":image", "@com_google_absl//absl/strings", diff --git a/tensorflow/core/kernels/mlir_generated/BUILD b/tensorflow/core/kernels/mlir_generated/BUILD index 1d18e41d3ef..062f87e745f 100644 --- a/tensorflow/core/kernels/mlir_generated/BUILD +++ b/tensorflow/core/kernels/mlir_generated/BUILD @@ -92,7 +92,9 @@ tf_cuda_cc_test( name = "gpu_tanh_test", size = "small", srcs = if_mlir_generated_gpu_kernels_enabled(["gpu_tanh_test.cc"]), - tags = tf_cuda_tests_tags(), + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171341759): re-enable. + ], deps = [ "//tensorflow/core:framework", "//tensorflow/core:framework_internal", @@ -109,7 +111,9 @@ tf_cuda_cc_test( name = "gpu_abs_test", size = "small", srcs = if_mlir_generated_gpu_kernels_enabled(["gpu_abs_test.cc"]), - tags = tf_cuda_tests_tags(), + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171341759): re-enable. + ], deps = [ "//tensorflow/core:framework", "//tensorflow/core:framework_internal", diff --git a/tensorflow/core/util/BUILD b/tensorflow/core/util/BUILD index 0630cb56ba0..e8179d33d7e 100644 --- a/tensorflow/core/util/BUILD +++ b/tensorflow/core/util/BUILD @@ -703,6 +703,9 @@ tf_cuda_only_cc_test( srcs = [ "gpu_kernel_helper_test.cu.cc", ], + tags = [ + "no_cuda_asan", # TODO(b/171342366): re-enable. + ], deps = [ "//tensorflow/core:test", "//tensorflow/core:test_main", diff --git a/tensorflow/python/BUILD b/tensorflow/python/BUILD index 20c1da93d0c..c892dd793bb 100644 --- a/tensorflow/python/BUILD +++ b/tensorflow/python/BUILD @@ -5198,6 +5198,9 @@ cuda_py_test( data = ["//tensorflow/core:image_testdata"], python_version = "PY3", shard_count = 16, + tags = [ + "no_cuda_asan", # TODO(b/171511582): re-enable. + ], deps = [ ":array_ops", ":client", diff --git a/tensorflow/python/kernel_tests/BUILD b/tensorflow/python/kernel_tests/BUILD index 2f5272895d2..21c27ea74e4 100644 --- a/tensorflow/python/kernel_tests/BUILD +++ b/tensorflow/python/kernel_tests/BUILD @@ -380,6 +380,9 @@ cuda_py_test( name = "cudnn_deterministic_ops_test", size = "small", srcs = ["cudnn_deterministic_ops_test.py"], + tags = [ + "no_cuda_asan", # TODO(b/171509035): re-enable. + ], xla_enable_strict_auto_jit = True, deps = [ ":cudnn_deterministic_base", @@ -390,6 +393,9 @@ cuda_py_test( name = "cudnn_deterministic_test", size = "small", srcs = ["cudnn_deterministic_test.py"], + tags = [ + "no_cuda_asan", # TODO(b/171509035): re-enable. + ], deps = [ ":cudnn_deterministic_base", ], diff --git a/tensorflow/stream_executor/cuda/BUILD b/tensorflow/stream_executor/cuda/BUILD index 7086217fa8e..0ee227d51f2 100644 --- a/tensorflow/stream_executor/cuda/BUILD +++ b/tensorflow/stream_executor/cuda/BUILD @@ -142,7 +142,9 @@ cc_library( tf_cuda_cc_test( name = "cuda_driver_test", srcs = ["cuda_driver_test.cc"], - tags = tf_cuda_tests_tags(), + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171512140): re-enable. + ], deps = [ "//tensorflow/core:test", "//tensorflow/core:test_main", @@ -154,7 +156,9 @@ tf_cuda_cc_test( tf_cuda_cc_test( name = "memcpy_test", srcs = ["memcpy_test.cc"], - tags = tf_cuda_tests_tags(), + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171512140): re-enable. + ], deps = [ "//tensorflow/core:test", "//tensorflow/core:test_main", @@ -658,7 +662,9 @@ cc_library( tf_cuda_cc_test( name = "redzone_allocator_test", srcs = ["redzone_allocator_test.cc"], - tags = tf_cuda_tests_tags(), + tags = tf_cuda_tests_tags() + [ + "no_cuda_asan", # TODO(b/171512140): re-enable. + ], deps = [ ":cuda_activation", ":cuda_gpu_executor",