experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix the vz-line-chart resize on redraw

Browse Source 
This fixes the expand button resizing wrongly. This was due to getting old
width and height when calling setViewBox(). Now it uses the bounding box to
get the width and height directly from the SVG.
Change: 131435410
This commit is contained in:
Renato Utsch 2016-08-26 12:33:15 -08:00 committed by TensorFlower Gardener
parent ec1077aae8
commit 8c37911d86
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tensorflow/tensorboard/components/vz-line-chart/vz-line-chart.ts
View File

@ -512,7 +512,6 @@ module VZ {
this.setViewBox(); this.setViewBox();
} }
/** There's an issue in Chrome where the svg overflow is a bit /** There's an issue in Chrome where the svg overflow is a bit
* "flickery". There is a border on the gridlines on the extreme edge of the * "flickery". There is a border on the gridlines on the extreme edge of the
* chart, which behaves inconsistently and causes the screendiffing tests to * chart, which behaves inconsistently and causes the screendiffing tests to
@ -520,9 +519,11 @@ module VZ {
* setting the viewBox on the containing svg. * setting the viewBox on the containing svg.
*/ */
private setViewBox() { private setViewBox() {
let w = this.outer.width(); let svg = this.targetSVG.node() as HTMLElement;
let h = this.outer.height(); let brect = svg.getBoundingClientRect();
this.targetSVG.attr('viewBox', `0 0 ${w+1} ${h+1}`); let w = brect.width;
let h = brect.height;
this.targetSVG.attr('viewBox', `0 0 ${w + 1} ${h + 1}`);
} }
public redraw() { public redraw() {