experiments/STT-tensorflow
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Emit warning for op not modeled in dialect.

Browse Source 
Unmodeled ops are treated very conservatively. Until the dialect fallback hook for querying effects is completed, these will all be marked as having side-effects. Warn for unmodeled op types.

PiperOrigin-RevId: 349589705
Change-Id: If3b4621050c5e53f773f8a518caf2c32ddbc7328
This commit is contained in:
Jacques Pienaar 2020-12-30 12:37:58 -08:00 committed by TensorFlower Gardener
parent b2a7c3d9da
commit 89310df4bc
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tensorflow/compiler/mlir/tensorflow/translate/import_model.cc
View File

@ -440,6 +440,9 @@ class ImporterBase {
protected:
// Maps feed as TensorId to new Placeholder node name.
absl::flat_hash_map<TensorId, absl::string_view> remapped_feeds_;
// All the TF ops encountered that aren't modelled in dialect.
llvm::DenseSet<mlir::Identifier> unmodelled_op_types_;
};
// Returns true if the node with given name has a non primary output that is
@ -1784,6 +1787,19 @@ mlir::Operation* ImporterBase::CreateOperation(
}
}
mlir::OperationName name = inner_op->getName();
if (!name.getAbstractOperation() &&
// Skip unmodelled ops that are handled differently.
(node_type_name != "_Arg" && node_type_name != "_Retval")) {
if (unmodelled_op_types_.insert(name.getIdentifier()).second) {
LOG(WARNING) << "Unmodelled op type `" << node.type_string() << "`"
<< (node.op_def().is_stateful()
? " is stateful but effects not modelled"
: " is not stateful but will be treated as such "
"conservatively");
}
}
// Add the terminator for the island
island_builder.create<mlir::tf_executor::YieldOp>(result.location,
inner_op->getResults());